Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 BUG: Emojis mess with mapping inside inline script tags #660

Closed
vrifox opened this issue Sep 28, 2023 · 2 comments
Closed

🐛 BUG: Emojis mess with mapping inside inline script tags #660

vrifox opened this issue Sep 28, 2023 · 2 comments
Labels
- P4: important Violate documented behavior or significantly improves performance (priority)

Comments

@vrifox
Copy link

vrifox commented Sep 28, 2023

Describe the Bug

Everything in onsubmit gets “eaten” on every save when using Emojis!

Steps to Reproduce

  1. npm init astro using sample files, typescript strict on
  2. In src/components/Card.astro replace → with an Emoji (example: 🌕)
  3. Add <form onsubmit="event.preventDefault()"></form> after the a tag
  4. Activate autoformat on save in VSCodium (Setting)
  5. Error! Everything in onsubmit gets “eaten” on every save!
@Princesseuh
Copy link
Member

This particular issue has been fixed by #681, however there still seems to be some mapping problems when using multiple-bytes characters like emojis

@Princesseuh Princesseuh changed the title 🐛 BUG: Emojis eat onsubmit="" attribute content 🐛 BUG: Emojis mess with mapping inside inline script tags Nov 12, 2023
@Princesseuh Princesseuh added bug - P4: important Violate documented behavior or significantly improves performance (priority) and removed bug labels Nov 12, 2023
@Princesseuh Princesseuh mentioned this issue Apr 26, 2024
Closed
@Princesseuh
Copy link
Member

Closing in favour of #862, since this issue was dedicated to another issue that has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- P4: important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Princesseuh @vrifox