Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): fix syntax highlighting with diff-like syntax example #1477

Merged
merged 2 commits into from
Feb 8, 2024
Merged

i18n(es): fix syntax highlighting with diff-like syntax example #1477

merged 2 commits into from
Feb 8, 2024

Conversation

HiDeoo
Copy link
Member

@HiDeoo HiDeoo commented Feb 8, 2024

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

While reviewing a pull request, I accidentally stumbled upon issues with the authoring content guide for the syntax highlighting with diff-like syntax example:

  • Extra '
  • Markdown example not matching the rendered output

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f1540e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Feb 8, 2024
@vercel Vercel
Copy link

vercel bot commented Feb 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Feb 8, 2024 9:00pm

delucis
delucis approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Not sure if you want to wait for a check on the Spanish translation (paging @dreyfus92 and @kevinzunigacuellar), no blocks from me!

kevinzunigacuellar
kevinzunigacuellar approved these changes Feb 8, 2024
View reviewed changes
Copy link
Sponsor Member

@kevinzunigacuellar kevinzunigacuellar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto señor HiDeoo! 💜

dreyfus92
dreyfus92 approved these changes Feb 8, 2024
View reviewed changes
Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No sabía que @HiDeoo hablaba español 😱, LGTM ✅

@HiDeoo
Copy link
Member Author

HiDeoo commented Feb 8, 2024

Wow, did not expect so many reviews during my break, amazing! Thanks everyone 🚀

@HiDeoo HiDeoo merged commit e4d5451 into withastro:main Feb 8, 2024
9 checks passed
@HiDeoo HiDeoo deleted the hd-i18n-es-fix-ec-diff-example branch February 8, 2024 21:02
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Feb 10, 2024
@HiDeoo
Merge branch 'main' into hd-virtual-pages
2107f4a 
* main: (96 commits)
  [ci] format
  i18n(ko-KR): update `manual-setup.mdx` (withastro#1482)
  i18n(ko-KR): update `community-content.mdx` (withastro#1483)
  [ci] format
  [ci] release (withastro#1481)
  [ci] format
  Make Starlight compatible with server output mode (withastro#1454)
  [i18nIgnore] community content: article description copy edit (withastro#1408)
  [ci] format
  i18n(it): Updated plugins.md and community-content.mdx (withastro#1480)
  i18n(fr): update `resources/community-content` (withastro#1479)
  [ci] format
  i18n(it): Modified everything in the /guides folder (withastro#1456)
  i18n(it): Modified frontmatter.md and overrides.md (withastro#1457)
  i18n(es): fix syntax highlighting with `diff`-like syntax example (withastro#1477)
  Add CodingCat.dev stream video to community content page (withastro#1475)
  i18n(fr): fix frontmatter `label` default value translation (withastro#1476)
  [ci] format
  [ci] release (withastro#1474)
  Set default color theme in template (withastro#1473)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

@kevinzunigacuellar kevinzunigacuellar kevinzunigacuellar approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HiDeoo @delucis @kevinzunigacuellar @dreyfus92