Set default color theme in template #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3fea4c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
size-limit report 📦
|
HiDeoo
approved these changes
Feb 8, 2024
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
Feb 10, 2024
* main: (96 commits) [ci] format i18n(ko-KR): update `manual-setup.mdx` (withastro#1482) i18n(ko-KR): update `community-content.mdx` (withastro#1483) [ci] format [ci] release (withastro#1481) [ci] format Make Starlight compatible with server output mode (withastro#1454) [i18nIgnore] community content: article description copy edit (withastro#1408) [ci] format i18n(it): Updated plugins.md and community-content.mdx (withastro#1480) i18n(fr): update `resources/community-content` (withastro#1479) [ci] format i18n(it): Modified everything in the /guides folder (withastro#1456) i18n(it): Modified frontmatter.md and overrides.md (withastro#1457) i18n(es): fix syntax highlighting with `diff`-like syntax example (withastro#1477) Add CodingCat.dev stream video to community content page (withastro#1475) i18n(fr): fix frontmatter `label` default value translation (withastro#1476) [ci] format [ci] release (withastro#1474) Set default color theme in template (withastro#1473) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Both dark and light Starlight appears when JS disabled #1470
We are not currently setting
data-themeby default, only when a small inline script runs:starlight/packages/starlight/components/ThemeProvider.astro
Line 14 in fb89bd1
For most styles this isn’t an issue because we set dark theme variables on
:root, light theme variables on[data-theme="light"]. But ourlight:sl-hiddenanddark:sl-hiddenclasses expectdata-themeto be set.To resolve this, this PR sets
data-theme="dark"in the prerendered HTML, so we are not dependent on JS running in order for those styles to work.There should be no behaviour change for users running JS, only this bug fix for those without.
Alternative solutions
I considered an alternative solution of updating the
dark:sl-hiddenstyle to work whendata-themeis not set:But given that it seems like a whole class of potential bugs could be caused by missing
data-theme(including potentially in user code), it seemed safest to set the default value at source.