Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(es): update sidebar #1767

Merged
merged 5 commits into from
Apr 23, 2024
Merged

i18n(es): update sidebar #1767

merged 5 commits into from
Apr 23, 2024

Conversation

dreyfus92
Copy link
Member

Description

  • Closes # N/A
  • What does this PR change? Give us a brief description.
    Updates sidebar based on this commit 36715ed

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1c83046

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 23, 2024 7:55am

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Apr 18, 2024
HiDeoo
HiDeoo requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 👍

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist. I left a few questions/suggestions, mostly some minor changes and also 1 question regarding the translation of some terms like constellations, moons, and stars (as this is something we have been doing in other translations).

docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
@dreyfus92
Copy link
Member Author

Thank you @HiDeoo for the amazing review 😁

HiDeoo
HiDeoo requested changes Apr 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my bad, I only suggested the first 2 occurrences as I did not know if that was correct and wanted your input first but considering it's fine, I added new suggestions for all occurrences with references for new ones.

docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/es/guides/sidebar.mdx Outdated Show resolved Hide resolved
@dreyfus92 @HiDeoo
Apply more suggestions from HiDeoo's review.
a6ea8e5 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
HiDeoo
HiDeoo approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I fixed a code highlight that was offset by 1 line but this looks pretty good to me 👍

@HiDeoo HiDeoo merged commit aa46a41 into withastro:main Apr 23, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-ts-composite-schema
636ab8f 
* main:
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
f682d22 
* main: (21 commits)
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#1761)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1760)
  i18n(fr): update `guides/sidebar` (withastro#1758)
  test: fix Windows path separator test issues (withastro#1759)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-draft-pages
cae8c5b 
* main: (63 commits)
  Add translation for copy button (withastro#1788)
  Update astro-expressive-code (withastro#1720)
  Fix type inference for extended i18n schemas (withastro#1786)
  Fix TypeScript schema error when using project references (withastro#1777)
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dreyfus92 @HiDeoo