-
-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n(zh-cn): Update sidebar.mdx
#1761
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thanks for the update and the review. Small question: I see that labels like "constellations", "moons", "stars", etc. are not translated and same for constellation names like "Andromeda". Is this on purpose? Do you think it's better to leave them in English? Is this a domain-specific where English is more common? Could something like "Andromeda" be translated to "仙女座" or this would not make sense? Of course, this is just a question, you definitely know better than me what is best in this case and I'd like your opinions. |
Hi HiDeoo, nice to communicate with you. I didn't translate these contents for the following reasons.
|
Nope. This is not English domain-specific. I think it would be fun to translate them too. |
Thanks you both for your feedback, really appreciated.
Indeed, and I guess having
What is done in the French translation for example, is that default labels are translated in French but we keep the original translations in Considering all this, maybe only "Resources" in this section should be translated as this is a safe one, right? |
Tiny update if this can help the discussion: we had the same discussion for the |
Well, I looked at the final result of the ko-KR, and I think it is reasonable, so I added the Chinese translation with reference to the ko-KR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, this is looking really great 👍
I left a few suggestions for the case of nested folders in autogenerated groups which would use the folder name (this would also becomes more obvious for readers with the translated content that we do not support this yet as nested folders would be using the folder name in English).
Except for that, everything looks in order to me.
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Thanks for your correction. I submitted your suggestions. Could you please confirm again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, this is looking really great. Thanks a lot for the updates 🙌
* main: (32 commits) i18n(pt-br): Update `getting-started.mdx` (withastro#1776) i18n(es): update `configuration` (withastro#1766) [ci] format Add TrueCharts to showcases (withastro#1773) i18n(zh-cn): Update `sidebar.mdx` (withastro#1761) i18n(ko-KR): update `sidebar.mdx` (withastro#1760) i18n(fr): update `guides/sidebar` (withastro#1758) test: fix Windows path separator test issues (withastro#1759) i18n(fr): Update `reference/configuration.mdx` from withastro#1729 (withastro#1757) docs: rewrite `guides/sidebar` examples to be more generic (withastro#1751) i18n(ja): Update community-content.mdx (withastro#1756) i18n(ja): Update configuration.mdx (withastro#1755) i18n(zh-cn): Update `configuration.mdx` (withastro#1753) i18n(ko-KR): update `configuration.mdx` (withastro#1752) docs: add caution about scripts processing when using head config (withastro#1729) i18n(es): update `community-content` (withastro#1740) i18n(pt-br): Update `resources/community-content.mdx` (withastro#1747) format: quick fix [ci] format [ci] format ...
* main: (21 commits) Update fa.json (withastro#1793) i18n(fr): update `resources/community-content.mdx` (withastro#1795) [ci] format i18n(ko-KR): update `community-content.mdx` (withastro#1794) [ci] format Adds Starlight in Next.js project video (withastro#1789) [ci] format i18n(ru): update translations (withastro#1783) i18n(id): Update getting-started.mdx (withastro#1778) Upgrade Lunaria and add Action (withastro#1768) [ci] format i18n(es): update `sidebar` (withastro#1767) i18n(pt-br): Update `getting-started.mdx` (withastro#1776) i18n(es): update `configuration` (withastro#1766) [ci] format Add TrueCharts to showcases (withastro#1773) i18n(zh-cn): Update `sidebar.mdx` (withastro#1761) i18n(ko-KR): update `sidebar.mdx` (withastro#1760) i18n(fr): update `guides/sidebar` (withastro#1758) test: fix Windows path separator test issues (withastro#1759) ...
Description
Update
sidebar.mdx
Upstream #1751