Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TrueCharts to showcases #1773

Merged
merged 3 commits into from
Apr 22, 2024
Merged

Add TrueCharts to showcases #1773

merged 3 commits into from
Apr 22, 2024

Conversation

PrivatePuffin
Copy link
Contributor

Description

Adds TrueCharts.org to Showcases.
Highlighting a significant number of Astro and Starlight components and multiple custom components

It also has thousands of pages of docs to showcase efficiency of Astro+Starlight as a docs backend

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ad3c2f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Apr 22, 2024 7:28am

@github-actions github-actions bot added the 📚 docs Documentation website changes label Apr 21, 2024
@astrobot-houston
Copy link
Collaborator

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@PrivatePuffin PrivatePuffin marked this pull request as ready for review April 21, 2024 12:41
HiDeoo
HiDeoo reviewed Apr 21, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission, really great website to add to the showcase 🤩

I noticed in the preview that the screenshot felt quite zoomed out compared to the other websites in the showcase.

What do you think about this screenshot instead which still matches the screenshot size but is a bit more zoomed in? I personally think this could make it a bit more recognisable.

truecharts org

@PrivatePuffin
Copy link
Contributor Author

Thanks for your submission, really great website to add to the showcase 🤩

I noticed in the preview that the screenshot felt quite zoomed out compared to the other websites in the showcase.

What do you think about this screenshot instead which still matches the screenshot size but is a bit more zoomed in? I personally think this could make it a bit more recognisable.

truecharts org

Totally agree, good catch!

HiDeoo
HiDeoo approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree, good catch!

Great, I updated the image to the suggested one and this looks perfect to me 👍

@HiDeoo HiDeoo merged commit 815ec57 into withastro:main Apr 22, 2024
9 checks passed
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 22, 2024
@HiDeoo
Merge branch 'main' into hd-style-details
ade0395 
* main: (32 commits)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#1761)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1760)
  i18n(fr): update `guides/sidebar` (withastro#1758)
  test: fix Windows path separator test issues (withastro#1759)
  i18n(fr): Update `reference/configuration.mdx` from withastro#1729 (withastro#1757)
  docs: rewrite `guides/sidebar` examples to be more generic (withastro#1751)
  i18n(ja): Update community-content.mdx (withastro#1756)
  i18n(ja): Update configuration.mdx (withastro#1755)
  i18n(zh-cn): Update `configuration.mdx` (withastro#1753)
  i18n(ko-KR): update `configuration.mdx` (withastro#1752)
  docs: add caution about scripts processing when using head config (withastro#1729)
  i18n(es): update `community-content` (withastro#1740)
  i18n(pt-br): Update `resources/community-content.mdx` (withastro#1747)
  format: quick fix
  [ci] format
  [ci] format
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-refactor-ts-composite-schema
636ab8f 
* main:
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-feat-tabs-sync
f682d22 
* main: (21 commits)
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  i18n(zh-cn): Update `sidebar.mdx` (withastro#1761)
  i18n(ko-KR): update `sidebar.mdx` (withastro#1760)
  i18n(fr): update `guides/sidebar` (withastro#1758)
  test: fix Windows path separator test issues (withastro#1759)
  ...
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Apr 30, 2024
@HiDeoo
Merge branch 'main' into hd-draft-pages
cae8c5b 
* main: (63 commits)
  Add translation for copy button (withastro#1788)
  Update astro-expressive-code (withastro#1720)
  Fix type inference for extended i18n schemas (withastro#1786)
  Fix TypeScript schema error when using project references (withastro#1777)
  Update fa.json (withastro#1793)
  i18n(fr): update `resources/community-content.mdx` (withastro#1795)
  [ci] format
  i18n(ko-KR): update `community-content.mdx` (withastro#1794)
  [ci] format
  Adds Starlight in Next.js project video (withastro#1789)
  [ci] format
  i18n(ru): update translations (withastro#1783)
  i18n(id): Update getting-started.mdx (withastro#1778)
  Upgrade Lunaria and add Action (withastro#1768)
  [ci] format
  i18n(es): update `sidebar` (withastro#1767)
  i18n(pt-br): Update `getting-started.mdx` (withastro#1776)
  i18n(es): update `configuration` (withastro#1766)
  [ci] format
  Add TrueCharts to showcases (withastro#1773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PrivatePuffin @astrobot-houston @HiDeoo