Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Patreon social link #892

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Add Patreon social link #892

merged 4 commits into from
Oct 13, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Oct 13, 2023

What kind of changes does this PR include?

  • Changes to Starlight code

Description

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: f9e0091

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 13, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit f9e0091
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/652955251298010008d41cd1

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Oct 13, 2023
@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Oct 13, 2023

size-limit report 📦

Path Size
/index.html 5.13 KB (0%)
/_astro/*.js 19.27 KB (0%)
/_astro/*.css 9.63 KB (0%)

@@ -97,4 +97,6 @@ export const Icons = {
'<path d="M19 4H5a3 3 0 0 0-3 3v10a3 3 0 0 0 3 3h14a3 3 0 0 0 3-3V7a3 3 0 0 0-3-3Zm-.41 2-5.88 5.88a1 1 0 0 1-1.42 0L5.41 6ZM20 17a1 1 0 0 1-1 1H5a1 1 0 0 1-1-1V7.41l5.88 5.88a3 3 0 0 0 4.24 0L20 7.41Z"/>',
reddit:
'<path d="M14.41 16.87a3.38 3.38 0 0 1-2.37.63 3.37 3.37 0 0 1-2.36-.63 1 1 0 0 0-1.42 1.41 5.11 5.11 0 0 0 3.78 1.22 5.12 5.12 0 0 0 3.78-1.22 1 1 0 1 0-1.41-1.41ZM9.2 15a1 1 0 1 0-1-1 1 1 0 0 0 1 1Zm6-2a1 1 0 1 0 1 1 1 1 0 0 0-1-1Zm7.8-1.22a3.77 3.77 0 0 0-6.8-2.26 16.5 16.5 0 0 0-3.04-.48l.85-5.7 2.09.7a3 3 0 0 0 6-.06v-.02a3.03 3.03 0 0 0-3-2.96 2.98 2.98 0 0 0-2.34 1.16l-3.24-1.1a1 1 0 0 0-1.3.8l-1.09 7.17a16.66 16.66 0 0 0-3.34.49 3.77 3.77 0 0 0-6.22 4.23A4.86 4.86 0 0 0 1 16c0 3.92 4.83 7 11 7s11-3.08 11-7a4.86 4.86 0 0 0-.57-2.25 3.78 3.78 0 0 0 .57-1.97ZM19.1 3a1 1 0 1 1-1 1 1.02 1.02 0 0 1 1-1ZM4.77 10a1.76 1.76 0 0 1 .88.25A9.98 9.98 0 0 0 3 11.92v-.14A1.78 1.78 0 0 1 4.78 10ZM12 21c-4.88 0-9-2.29-9-5s4.12-5 9-5 9 2.29 9 5-4.12 5-9 5Zm8.99-9.08a9.98 9.98 0 0 0-2.65-1.67 1.76 1.76 0 0 1 .88-.25A1.78 1.78 0 0 1 21 11.78l-.01.14Z"/>',
patreon:
'<path d="M1033 324.4c0-137.8-107.5-250.9-233.6-291.6C643-18 436.6-10.5 287.2 60 106 145.4 49.2 332.6 47 519.3c-1.8 153.5 13.5 557.8 241.6 560.7 169.4 2.1 194.7-216.2 273-321.3 55.8-74.9 127.6-96 216-117.9 152-37.6 255.6-157.5 255.3-316.3z"/>',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like huge coordinates, would that render properly in Starlight?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope — just pushed a fix 😁

@delucis delucis added the 🌟 patch Change that triggers a patch release label Oct 13, 2023
@delucis
Copy link
Member Author

delucis commented Oct 13, 2023

@HiDeoo
Copy link
Member

HiDeoo commented Oct 13, 2023

@HiDeoo I think it looks OK now? deploy-preview-892--astro-starlight.netlify.app/guides/components/#all-icons

Looks perfect to me 👍 (I'm on phone tho so maybe not the best ^^)

Out of curiosity, what tool did you use to scale down the path coordinates?

@delucis
Copy link
Member Author

delucis commented Oct 13, 2023

Out of curiosity, what tool did you use to scale down the path coordinates?

I tried like 4 different online “SVG resizers” none of which worked and so plopped it in Figma and did it there 😅

@delucis delucis merged commit 2b30321 into main Oct 13, 2023
9 checks passed
@delucis delucis deleted the chris/patreon branch October 13, 2023 14:42
@astrobot-houston astrobot-houston mentioned this pull request Oct 13, 2023
@HiDeoo
Copy link
Member

HiDeoo commented Oct 13, 2023

Ah yeah, that's how I usually do it too, kinda hoped you had a 1-click upload & resize magical tool link ^^ Thanks

@delucis
Copy link
Member Author

delucis commented Oct 13, 2023

One must exist somewhere! It’s just an SEO nightmare with loads of marketing for suites of bad online graphics editor tools, so hard to find. Maybe a GitHub search would do better at uncovering something.

Like this, which I needed the other day: https://svg-path-visualizer.netlify.app/

HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 15, 2023
* main: (42 commits)
  docs: refactor sidebar label translations examples to use tags with regional subtags (withastro#881)
  Add Nostalgist.js docs to showcase (withastro#900)
  i18n(id): Fix environmental-impact.md translation (withastro#899)
  i18n(es): Update `customization.mdx`, `i18n.mdx` & `configuration.md` (withastro#897)
  i18n(ko): update `configuration.md` (withastro#896)
  i18n(ko): update `i18n.mdx` (withastro#895)
  i18n(ko): update `customization.mdx` (withastro#894)
  [ci] format
  i18n(id): translate guides/components.mdx and guides/project-structure.mdx (withastro#898)
  [ci] format
  [ci] release (withastro#865)
  Add Patreon social link (withastro#892)
  [ci] format
  Add Ukrainian language support (withastro#891)
  i18n(id): Translate more pages and improve existing translations (withastro#859)
  [ci] format
  feat: add Reddit social icon (withastro#854)
  [ci] format
  i18n(ru): added translations for components, css-and-tailwind, environmental-impact, project-structure pages (withastro#888)
  i18n(id): translate `guides/authoring-content.md` (withastro#863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes 🌟 patch Change that triggers a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add patreon as a social link
3 participants