Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(id): Translate more pages and improve existing translations #859

Merged
merged 10 commits into from
Oct 13, 2023
Merged

i18n(id): Translate more pages and improve existing translations #859

merged 10 commits into from
Oct 13, 2023

Conversation

oggnimodd
Copy link
Contributor

@oggnimodd oggnimodd commented Oct 11, 2023

What kind of changes does this PR include?

  • Changes or translations of Starlight docs site content

Description

  • Improve existing Indonesian content translations inside docs/id
  • Translate environmental-impact.md and showcase.mdx to Indonesian
  • Improve Indonesian translation of tableOfContents.overview

I also plan to translate more pages from 'Guides' and 'Reference,' but I think will create separate pull requests for those pages

@changeset-bot
Copy link

changeset-bot bot commented Oct 11, 2023

🦋 Changeset detected

Latest commit: a622699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Oct 11, 2023

👷 Deploy Preview for astro-starlight processing.

Name Link
🔨 Latest commit a622699
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/652950e3e0180a0008d51c0e

@github-actions github-actions bot added 📚 docs Documentation website changes 🌟 core Changes to Starlight’s main package labels Oct 11, 2023
Copy link
Collaborator

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @oggnimodd! Just one quick question on this one.


Tertarik bagaimana perbandingannya dengan _framework_ dokumentasi lainnya? Tes ini dengan [Website Carbon Calculator][wcc] membandingkan halaman-halaman serupa yang dibangun dengan _tool_ yang berbeda.

| Framework | CO₂ per page visit |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this also be translated?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I’d like to merge this now, so that we can release the change to id.json — would love a follow-up PR to fix the English here if needed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that! My bad, it should be translated. I'll create a follow-up PR to fix it.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts label Oct 13, 2023
@delucis delucis merged commit eaa7a90 into withastro:main Oct 13, 2023
9 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Oct 13, 2023
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request Oct 15, 2023
* main: (42 commits)
  docs: refactor sidebar label translations examples to use tags with regional subtags (withastro#881)
  Add Nostalgist.js docs to showcase (withastro#900)
  i18n(id): Fix environmental-impact.md translation (withastro#899)
  i18n(es): Update `customization.mdx`, `i18n.mdx` & `configuration.md` (withastro#897)
  i18n(ko): update `configuration.md` (withastro#896)
  i18n(ko): update `i18n.mdx` (withastro#895)
  i18n(ko): update `customization.mdx` (withastro#894)
  [ci] format
  i18n(id): translate guides/components.mdx and guides/project-structure.mdx (withastro#898)
  [ci] format
  [ci] release (withastro#865)
  Add Patreon social link (withastro#892)
  [ci] format
  Add Ukrainian language support (withastro#891)
  i18n(id): Translate more pages and improve existing translations (withastro#859)
  [ci] format
  feat: add Reddit social icon (withastro#854)
  [ci] format
  i18n(ru): added translations for components, css-and-tailwind, environmental-impact, project-structure pages (withastro#888)
  i18n(id): translate `guides/authoring-content.md` (withastro#863)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package 📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants