-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Reddit social icon #854
Conversation
🦋 Changeset detectedLatest commit: b6061e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello! Thank you for opening your first PR to Starlight! ✨
Here’s what will happen next:
-
Our GitHub bots will run to check your changes.
If they spot any issues you will see some error messages on this PR.
Don’t hesitate to ask any questions if you’re not sure what these mean! -
In a few minutes, you’ll be able to see a preview of your changes on Netlify 🤩
-
One or more of our maintainers will take a look and may ask you to make changes.
We try to be responsive, but don’t worry if this takes a few days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution 🙌
- This change will require a changeset like this one to inform our users about the new icon (you can generate one using the
pnpm exec changeset
command) - Would you mind reverting the changes to non-English doc pages that were introduced and only keep the changes for the English version? We usually only update the English pages and leave changes to the translations to our translators as this makes it easier for the Starlight translation tracker to keep track of the changes.
Sure no problem @HiDeoo ! I have updated my commit to add the changeset and remove the international updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, this looks good to me 🙌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this @mehalter! Added one suggestion but other than that, this looks great and we can get it out in our next patch release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Should be good to go for our next release 🙌
We’ll merge it shortly before release to avoid updating the docs site until the Reddit icon is available.
Awesome sounds great! @delucis I also went ahead and looked at optimizing the rest of the UI icons in that file as some of them are much larger than they need to be. I went ahead and opened another PR. Let me know if this is something you are interested in or if you would prefer it be in this PR as well. |
Nice that’s very helpful — thanks @mehalter. A separate PR makes sense for that I think 🙌 |
With that other large change to the Thanks for letting me make some small contributions. Great job on this project, it is awesome! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resolving those — looks good!
* main: (42 commits) docs: refactor sidebar label translations examples to use tags with regional subtags (withastro#881) Add Nostalgist.js docs to showcase (withastro#900) i18n(id): Fix environmental-impact.md translation (withastro#899) i18n(es): Update `customization.mdx`, `i18n.mdx` & `configuration.md` (withastro#897) i18n(ko): update `configuration.md` (withastro#896) i18n(ko): update `i18n.mdx` (withastro#895) i18n(ko): update `customization.mdx` (withastro#894) [ci] format i18n(id): translate guides/components.mdx and guides/project-structure.mdx (withastro#898) [ci] format [ci] release (withastro#865) Add Patreon social link (withastro#892) [ci] format Add Ukrainian language support (withastro#891) i18n(id): Translate more pages and improve existing translations (withastro#859) [ci] format feat: add Reddit social icon (withastro#854) [ci] format i18n(ru): added translations for components, css-and-tailwind, environmental-impact, project-structure pages (withastro#888) i18n(id): translate `guides/authoring-content.md` (withastro#863) ...
What kind of changes does this PR include?
Description
This adds Reddit as a social icons for projects that want to be able to add links to their official subreddit.