Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] git add to offer a wildcard extension #73

Closed
MartinPacker opened this issue Mar 24, 2021 · 6 comments
Closed

[git] git add to offer a wildcard extension #73

MartinPacker opened this issue Mar 24, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@MartinPacker
Copy link

MartinPacker commented Mar 24, 2021

When I update the docs for one of my GitHub projects (md2pptx as it happens) I generate a bunch of user_guide.* files. It's my practice to add them with the following command:

git add user_guide.*

Today autocomplete offers each file individually. In my case I have several I want to add all at once. I like the individual file prompting but I'd like autocomplete to also offer the generic user_guide.*.

@mschrage mschrage added the enhancement New feature or request label Apr 2, 2021
@mschrage
Copy link
Member

mschrage commented Apr 2, 2021

I like this idea a lot! To summarize: we should check to see if any of the staged files share a common prefix and then add the corresponding wildcard pattern as a suggestion?

@mschrage mschrage changed the title git add to offer a wildcard extension git: git add to offer a wildcard extension Apr 2, 2021
@brendanfalk brendanfalk changed the title git: git add to offer a wildcard extension [git] git add to offer a wildcard extension Apr 7, 2021
@brendanfalk
Copy link
Member

Another user comment

I was trying to git add a folder of changes eg:

  • app/web/files/change.js
  • app/web/files/otherthing.js

I wanted the autocomplete to stop at git add app/web/files, but there's no way to do this outside of breaking the autocomplete interface by typing a nonsensical character, or escaping the interface.

@QuiiBz
Copy link
Contributor

QuiiBz commented Jul 9, 2021

Merged in #349, thanks to everyone!

@QuiiBz QuiiBz closed this as completed Jul 9, 2021
@brendanfalk brendanfalk reopened this Jul 9, 2021
@brendanfalk
Copy link
Member

Going to reopen this. This PR uses two generators which is going to be really slow. We should do this with 1 generator.

@QuiiBz
Copy link
Contributor

QuiiBz commented Jul 9, 2021

There are many other specs that use 2 generators, I don't think that really slow. We should benchmark this to see if it's really slow or not.

@QuiiBz
Copy link
Contributor

QuiiBz commented Jul 13, 2021

Merged again in #358, using one generator (which is now really faster!)

@QuiiBz QuiiBz closed this as completed Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants