Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete not working for the following ZSH Themes #12

Closed
brendanfalk opened this issue Nov 8, 2020 · 5 comments
Closed

Autocomplete not working for the following ZSH Themes #12

brendanfalk opened this issue Nov 8, 2020 · 5 comments

Comments

@brendanfalk
Copy link
Member

brendanfalk commented Nov 8, 2020

Fig is not currently compatible with the following ZSH themes:

  • None that we know of

Themes Fig was previously incompatible with:

  • https://github.com/romkatv/powerlevel10k (fixed in version v1.0.31)
    → was not working as powerlevel10k spawns many background zsh processes. This was affecting our ability to get the cwd for the shell you're currently in

This issue will remain open and will be updated over time

@brendanfalk
Copy link
Member Author

brendanfalk commented Nov 8, 2020

Why does this happen?

Fig checks which process is currently running in your terminal. We run ps then get the last process in the list for a given terminal.

We don’t show Fig when it’s not bash or zsh, and we show a pared back version of Fig for an ssh session. Otherwise if you’re in a process like nano or vim etc we don’t show Fig

This screenshot shows an example of what happens with the powerlevel10k theme:
https://files.slack.com/files-pri/T015ZGD7L07-F01DU9Q3ULF/image.png

@brendanfalk
Copy link
Member Author

It could potentially be something to do with the instant-prompt in Powerlevel10k

More likely it is the git status message as shown in the file shared above

@dipakparmar
Copy link

@falky97 checked this on my setup with oh-my-zsh. Updating the zsh theme to default "robbyrussell" makes working autocomplete somehow but not properly, few issues with cwd (doesn't update) and icons on autocomplete (no icons for folder)

# ZSH_THEME="robbyrussell"
# ZSH_THEME="powerlevel10k/powerlevel10k"

Disabling theme fixes this. so maybe it's a conflict with zsh themes.

@brendanfalk
Copy link
Member Author

@dipakparmar Yes I noticed those issues too with different themes. However, they seem to go away after restarting iTerm/Terminal...

@brendanfalk
Copy link
Member Author

brendanfalk commented Nov 9, 2020 via email

@brendanfalk brendanfalk transferred this issue from withfig/autocomplete Dec 20, 2020
@withfig withfig locked as resolved and limited conversation to collaborators Jan 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants