-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
33: Client Mockups - [merged] #72
Comments
In GitLab by @11775820 on Sep 21, 2021, 16:00 requested review from @11712616 |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/models/exercises/exercise_attribute.dart line 1 I would rename this to |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/widgets/main_app_bar.dart line 27 Is it possible to turn this plain text title into a "link" (with the same text) to the start screen, i.e. the workout of today? |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/widgets/main_app_bar.dart line 46 I would restrict the display of the date picker to the start screen or screen when viewing a logged workout on a given day, respectively. As discussed privately, in combination with the comment about the |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/models/exercises/exercise_tag.dart line 1 As far as I understand, this class is used for distinguishing different muscle groups? If yes, I would rename it to |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/widgets/app_drawer.dart line 44 I would rename the |
In GitLab by @11712616 on Sep 22, 2021, 21:18 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 I know that the sketches I made are very confusing and I had not been quite sure about how this should look like myself; however, after some reconsideration, I would say that this |
In GitLab by @11712616 on Sep 23, 2021, 09:00 Commented on client/lib/widgets/main_app_bar.dart line 27 As discussed privately, this is not a good idea since it is uncommon and counter-intuitive. |
In GitLab by @11775820 on Sep 23, 2021, 11:06 Commented on client/lib/models/exercises/exercise_tag.dart line 1 I started with |
In GitLab by @11775820 on Sep 23, 2021, 11:06 Commented on client/lib/widgets/app_drawer.dart line 44 That would diverge even more from your sketches (you didn't even have the 'Workout Overview' in the drawer) require workouts to be able to exist independently from training programs such that programs just "consume" pre-existing workouts. That opens up the question if changes (e.g. adding an exercise to a workout that is in a training program) will propagate to the original one (which happens automatically if the program just referneces to the program) or if a workout to be incorporated in a program is just duplicated such that subsequent changes are not reflected in the source workouts. The workout overview is okay, but how are workouts to be used in programs handled? |
In GitLab by @11775820 on Sep 23, 2021, 11:06 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 ok. |
In GitLab by @11775820 on Sep 23, 2021, 12:40 Commented on client/lib/widgets/main_app_bar.dart line 46 changed this line in version 2 of the diff |
In GitLab by @11775820 on Sep 23, 2021, 12:40 Commented on client/lib/widgets/app_drawer.dart line 44 changed this line in version 2 of the diff |
In GitLab by @11775820 on Sep 23, 2021, 12:40 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 changed this line in version 2 of the diff |
In GitLab by @11775820 on Sep 23, 2021, 12:40 added 4 commits
|
In GitLab by @11775820 on Sep 23, 2021, 12:41 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 -> 90681fd7f3a428d1bad52312ad933e31161c74c0 |
In GitLab by @11775820 on Sep 23, 2021, 12:41 Commented on client/lib/widgets/main_app_bar.dart line 46 -> f0c6a5632836fcf9ef6e800c5da0e7dda9af0f73 |
In GitLab by @11775820 on Sep 23, 2021, 12:41 Commented on client/lib/models/exercises/exercise_attribute.dart line 1 As discussed in private, this has to be specified by the domain model and/or server and goes beyond the scope of simple UI mockups. |
In GitLab by @11775820 on Sep 23, 2021, 12:41 Commented on client/lib/widgets/app_drawer.dart line 44 -> rename: 6fc7a27e27342f04cff88e147b950d7cddbbc5b6 |
In GitLab by @11712616 on Sep 23, 2021, 12:46 Commented on client/lib/models/exercises/exercise_tag.dart line 1 I would stick with |
In GitLab by @11712616 on Sep 23, 2021, 12:46 Commented on client/lib/widgets/app_drawer.dart line 44 My bad - I somehow thought that we wanted to save workouts although we explicitly discussed this matter and agreed not to implement such functionality. Please forget the handling of workouts and the |
In GitLab by @11712616 on Sep 23, 2021, 12:46 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 I would like to revise my initial comment. The Firstly, Secondly, Lastly, Another possibility is to combine the This description and reasoning, respectively, probably goes in too much detail for the mockups. I just wanted to (try to) clarify my thoughts and explain what I have in mind so that for further work, we can possibly build upon this discussion. What are your thoughts? |
In GitLab by @11775820 on Sep 23, 2021, 14:01 Commented on client/lib/models/exercises/exercise_tag.dart line 1 changed this line in version 3 of the diff |
In GitLab by @11775820 on Sep 23, 2021, 14:01 added 2 commits
|
In GitLab by @11775820 on Sep 23, 2021, 14:02 Commented on client/lib/widgets/app_drawer.dart line 44 -> 64073bc40f699e28f16f26e1f714738e6d3eddcd As for the actually logged workouts, maybe something like |
In GitLab by @11775820 on Sep 23, 2021, 14:02 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 Sounds good. But what do you want now, the three buttons you mentioned in the beginning or the two buttons with a dialog? The latter option would help me because I have no idea what third icon I should use to distinguish the two "log" actions. However, it could be annoying to be asked the same thing over and over again when trying to log something. You decide. |
In GitLab by @11775820 on Sep 23, 2021, 14:02 Commented on client/lib/models/exercises/exercise_tag.dart line 1 -> e0ed28e0f9c487ea54c20ede107219c0d7f75844 |
In GitLab by @11712616 on Sep 23, 2021, 18:07 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 For now, I kind of have a slight tendency to the first option... I would suggest a dumbbell icon for |
In GitLab by @11775820 on Sep 23, 2021, 18:16 added 1 commit
|
In GitLab by @11775820 on Sep 23, 2021, 18:17 Commented on client/lib/widgets/workouts/workout_overview_screen.dart line 71 yes. |
In GitLab by @11712616 on Sep 23, 2021, 18:38 resolved all threads |
In GitLab by @11712616 on Sep 23, 2021, 18:38 approved this merge request |
In GitLab by @11775820 on Sep 23, 2021, 20:37 added 1 commit
|
In GitLab by @11775820 on Sep 23, 2021, 20:53 mentioned in commit 4cbef75 |
In GitLab by @11775820 on Sep 21, 2021, 16:00
Merges 33-client-mockups -> develop
Closes #33
In the real implementation, we need to put a little more thought into what data we want to receive with each request and how they are organized (right now, for the purpose of creating mockups as quickly as possible, it is very naive and objects that should e.g. be "local per training program" are reused in multiple programs for the sake of quickness).
If you get error regarding the localization (something with
AppLocalization
and errors atpackage:flutter_gen/...
imports), be sure to do aflutter clean
, followed by aflutter pub get
. Then, unfortunately, it might still be necessary to restart IntelliJ to get rid of the error messages (they are no real errors, building and running would still work fine, but popups and squiggly lines are annoying). This is a more or less known (or recurring) error in the Flutter IDE integration plugins.The text was updated successfully, but these errors were encountered: