Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚠️ Dropping Mocha support in Detox 20 ⚠️ #3193

Closed
noomorph opened this issue Jan 27, 2022 · 3 comments
Closed

⚠️ Dropping Mocha support in Detox 20 ⚠️ #3193

noomorph opened this issue Jan 27, 2022 · 3 comments

Comments

@noomorph
Copy link
Collaborator

Before you think the heading already tells the entire story, I must mention that being Test Runner Independent (as noted in README) still remains one of the values of Detox.

At the moment, there's already a considerable feature gap between Mocha and Jest integrations, and since we intend to keep improving the current integration with jest-circus and add more important bugfixes and features (multi-device support, canonically extending the matchers, etc), we have to choose a trade-off between:

  1. neglect the improvements and do nothing? 🤨 – not an option at all, because we love our product, first of all.
  2. leave Mocha integration as-is and keep developing the Jest counterpart – theoretically possible, but leaves a lot of legacy code and adds more regression testing, and the gap will keep growing – what is the value then?
  3. dive into the latest Mocha docs and try to develop an on-par integration – extra time and extra risks, and as a team, currently, we have no capacity to spread our efforts that wide.
  4. drop Mocha support, perform all the intended refactorings and feature addition, see where it has led us to, define how the ideal test runner protocol looks like for us, and after one more major release – get ready to embrace third-party integrations with the test runners.

Obviously, the future of number 4 is still vague and contains not fewer risks, but there I see an opening for a more optimistic storyline, where we eventually become able to provide 1st class support for many runners instead of one and a half (if we are honest).

@d4vidi @asafkorem @jonathanmos

@stale
Copy link

stale bot commented Feb 26, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back.

Thank you for your contributions!

For more information on bots in this reporsitory, read this discussion.

@noomorph
Copy link
Collaborator Author

noomorph commented Feb 27, 2022

Not stale, after the war we'll get back to the issue as well. 🇺🇦

UPD: Detox 20 is likely to be released between end-Sep and mid-Oct 2022.
The preview version is already available on NPM:

npm install detox@prerelease -D

@noomorph
Copy link
Collaborator Author

So we managed to resolve this Mocha issue even earlier. 💛💙
Done.

Please migrate: https://wix.github.io/Detox/docs/guide/migration#200

@noomorph noomorph unpinned this issue Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants