Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update outdated dependencies #3994

Open
stianjensen opened this issue Mar 22, 2023 · 3 comments
Open

Update outdated dependencies #3994

stianjensen opened this issue Mar 22, 2023 · 3 comments

Comments

@stianjensen
Copy link
Contributor

Describe your idea

Hi!

I noticed that Detox installs quite old versions of several dependencies (chalk, fs-extra, etc.)

I wanted to help updating these to a newer version, and was prompted by the CI check to create an issue for discussing changes to package.json

Here's my first PR that tackles updating chalk to a newer version (that still maintains node support with what Detox currently supports):
#3987

@asafkorem
Copy link
Contributor

Thanks @stianjensen! Sounds good 🙏🏼
I reviewed your PR. Generally, if there's a dependency that you think we should upgrade - you can open a PR for that, but please make sure to run our tests suite before. See our contributing guide for more guidance.

@noomorph
Copy link
Collaborator

@stianjensen , do you want to contribute some pull requests on this regard?

@github-actions
Copy link

Hello! We appreciate you bringing this issue to our attention.
It looks like this could be a valuable addition or fix to our project.
We believe that this feature would benefit greatly from contributions from the community,
even from first-time contributors.

If you're interested in contributing to this feature,
please take a look at our contribution guide.
It has all the information you need to know about how to submit a pull request and contribute to our project.

You're also welcome to join our Discord server
and discuss this feature with the collaborators or other contributors under the channel 'contributions'.

Please feel free to reach out to us if you have any questions, or need help with anything.
We appreciate your feedback and look forward to working with you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants