Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] dismissAllModals doesn't fully drops all the modals #4552

Closed
vshkl opened this issue Jan 9, 2019 · 2 comments
Closed

[V2] dismissAllModals doesn't fully drops all the modals #4552

vshkl opened this issue Jan 9, 2019 · 2 comments

Comments

@vshkl
Copy link

vshkl commented Jan 9, 2019

Issue Description

When dismissing all the modals via dismissAllModas and trying to open those modals again, an IDs collision happens.

Steps to Reproduce / Code Snippets / Screenshots

  • Show the first modal screen
  • Show the second modal screen from the componentDidApear from the first one
  • Dismiss all the modals from the second one
  • Try to show the first modal again

ezgif com-resize

Expected: the first and the second modals should be shown subsequently
Got: Exception 'Component id already exists screen.ModalOne' was thrown while invoking showModal has been thrown.

Demo app: https://github.com/vshkl/RNNDemo/tree/bug/dismiss-all-modals


Environment

  • React Native Navigation version: 2.5.1-snapshot.127
  • React Native version: 0.57.5
  • Platform(s) (iOS, Android, or both?): iOS
  • Device info (Simulator/Device? OS version? Debug/Release?): Simulator, 12.1, Debug
@stale
Copy link

stale bot commented Feb 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you believe the issue is still relevant, please test on the latest Detox and report back. Thank you for your contributions.

@stale stale bot added the 🏚 stale label Feb 8, 2019
@stale
Copy link

stale bot commented Feb 15, 2019

The issue has been closed for inactivity.

@stale stale bot closed this as completed Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant