Skip to content

Commit

Permalink
Text - default alignment (#2670)
Browse files Browse the repository at this point in the history 
* Text - removing default text alignment (set to left) to allow children to get parent alignment (issue is on iOS only)

* update snapshot tests - Button, AvatarScreen

* Replacing default textAlign with writingDirection to fix rtl

* Adding writingDirectionTypes and updating snapshot tests

* adding comment
  • Loading branch information
@Inbal-Tish
Inbal-Tish committed Jul 19, 2023
1 parent e48a2eb commit 2a2f962
Show file tree
Hide file tree
Showing 3 changed files with 78 additions and 71 deletions.
44 changes: 22 additions & 22 deletions demo/src/screens/__tests__/__snapshots__/AvatarScreen.spec.js.snap
View file
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -159,7 +159,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -289,7 +289,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
{
"fontFamily": "System",
Expand Down Expand Up @@ -342,7 +342,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -444,7 +444,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down Expand Up @@ -514,7 +514,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
{
"fontFamily": "System",
Expand Down Expand Up @@ -567,7 +567,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -669,7 +669,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down Expand Up @@ -797,7 +797,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -1048,7 +1048,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -1299,7 +1299,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -1501,7 +1501,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -1752,7 +1752,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2047,7 +2047,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2231,7 +2231,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2338,7 +2338,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down Expand Up @@ -2457,7 +2457,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2564,7 +2564,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down Expand Up @@ -2683,7 +2683,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2867,7 +2867,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
{
Expand Down Expand Up @@ -2969,7 +2969,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down Expand Up @@ -3079,7 +3079,7 @@ exports[`AvatarScreen renders screen 1`] = `
{
"backgroundColor": "transparent",
"color": "#20303C",
"textAlign": "left",
"writingDirection": "ltr",
},
undefined,
undefined,
Expand Down

0 comments on commit 2a2f962

Please sign in to comment.