Text - default alignment #2670
Merged
Text - default alignment #2670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n to get parent alignment (issue is on iOS only)
ethanshar
approved these changes
Jul 18, 2023
|
@Inbal-Tish Notice that once this is merged, it will break private snapshot tests, so I suggest to prepare a PR that fix them |
…Text_default_alignment # Conflicts: # src/components/text/index.tsx
prsvic
added a commit
to dialectlabs/react-native-ui-lib
that referenced
this pull request
Aug 30, 2023
* Picker - remove commented out code related to 'renderNativePicker' deprecated prop * Incubator.Dialog - fix RN Modal native calls on RN71 (wix#2573) * CharCounter now working with emojis (16-bit code) (wix#2570) * CharCounter now working with emojis (16-bit code) * Fixed review notes * SortableList - adding important note * fix wheelpicker in android (wix#2558) * fix wheelpicker in android * Removed initialNumToRender, removed style * removed itemLength variable * opt-out * added flatListProps to wheelPicker.api * added note to the api.json file * refactor the nore * fixed note * minor fix * Align LogService with console (wix#2577) Allow sending multiple params and allow (any) objects * Incubator.Dialog - fix test after RN71 bug fix (wix#2575) * Incubator.Dialog - fix test after RN71 bug fix * Forgot this * Replacing 'react-native-text-size' with wix fork (wix#2542) * Replacing 'react-native-text-size' with wix fork * fix version * Enable TS check on demo files and fix all errors (wix#2585) * Enable TS check on demo files and fix all errors * Code review fixes * Add space - test commit * Remove space * Revert changes in margin modifiers typings * SortableGridList tests (wix#2586) * Upgrade reanimated to 2.17 (wix#2587) * HintsScreen - allow configuration (wix#2590) * Move to reanimated 3 (wix#2593) * Move to reanimated 3 * Improve wording * FloatingPlaceHolder animation fix (wix#2591) * Picker - fix listProps type to be Partial (wix#2596) * Add setBreakpoints and getPageMargins (wix#2576) * Slider - adding 'migrate' prop to allow using Incubator.Silder (wix#2592) * GradientSlider - adding 'migrate' prop to allow using Incubator Silder instead of old implementation * fix lint and ts * Slider - add the 'migrate' prop to use Incubator.Slider * Incubator.Slider - fix how we apply 'tumbTintColor' to match old Slider * Demo screen - add the 'migrate' prop * remove duplicate prop declaretion * comments * adding prop to api json * pr comments fix * example margins * removing migrate from old screen --------- Co-authored-by: M-i-k-e-l <michaelle@wix.com> * iOS - change bundle id and set min deployment to iOS 13.0 (wix#2597) * iOS - set min deployment to iOS 13.0 * Demo - change bundle id to allow running on iOS device * DateTimePicket - add validate (wix#2601) * Feat/ Support subtitle in Modal.TopBar (wix#2594) * Support subtitle in Modal.TopBar * bodySmall * Add contribution link in the our main readme file * Incubator.Slider - fix onValueChange throttle (wix#2598) ColorPicker - add 'migrate' prop to use new SliderImplementation * Calendar demo screen - move items load to componentDidMount * Feat/ SortableList - add ItemMargin prop (wix#2561) * add ItemMargin prop * move height calculation * renaming * Prettify --------- Co-authored-by: M-i-k-e-l <michaelle@wix.com> * DateTimePicker - fix TextField migration related TS errors (wix#2604) * TextField and Switch/ forward id prop (wix#2608) * TextField: forward containerId prop * code-review * code-review * Calendar - Day - memoize everything * Fix the Wizard.Step style according to the guidelines (wix#2609) * Fix the Wizard.Step style according to the guidelines * changed bottom divider color * Release notes script - fix and improve (wix#2605) * Release notes script - fix and improve * Move logic to functions * Move silentPRs * Oops * Error in red + align a little to private * Support input params * Rename to Additional info (and add to PR template) + improve error message * Small fix * getItemIndex - improve comparison by not using isSameMonth tool * Calendar getItemIndex - revert fix * Calendar - getItemIndex - fix * Fix how we handle style in our Svg image component for web (wix#2612) * Fix how we handle style in our Svg image component for web * fix how we clone style object * GridView and SortableGridView - support tablet and other fixes (wix#2611) * GridView and SortableGridView - support tablet and other fixes * Cannot warn since we're already using this internally without setting * Include TouchableOpacityProps in SwitchProps (wix#2613) * Improving date utils (wix#2610) * Improving date utils * replacing function * revert function change * Moving 'inactive' day logic from Week to Day * Header - addMonths - improve flow * Header - convert to dateObject only for staticHeader * pr comments * Support passing labelProps to TabController item (wix#2615) * Incubator.Slider - fix types (wix#2616) * WheelPicker - Android - fix missing values when initialValue is sent (wix#2618) * Width and height props added to Icon, passed only in case of svg icon (wix#2583) * Width and height props added to Icon, passed only in case of svg icon * fixed review notes * passing iconSiez to svg image > The code looks good, you can merge if you've tested it (on both platforms) * fix: setNativeProps not supported on web (wix#2620) * Incubator.TextField - fix context menu not showing in centered and empty input (wix#2617) * Comment some code in calendar * Infra/ set infra for users recordings (wix#2437) * set recorder infra * update snapshots * remove default recorderTag * fix priority * add fs support to more components * update toast + api * fix merge * fix snapshots * unmask TextField label, floatingPlaceholder and charCounter * review fixes * add RecorderProps type * prettify * change to interface * formatting * move recorder typings to typings directory * fix chip api * IncubatorDialog - add topAccessory (wix#2621) * fix recorder typings (wix#2624) * export RecorderProps * fix export * Picker update items when children is changed (wix#2599) * Picker update items when children is changed * Code refactor * update api.json file * fixed review notes * refactor renderItem * items type update * Infra/test kit add props (wix#2619) * testkit - add props generics * Fix some TS errors and accessibility bugs * DateTimePicker - start deprecation of moment props (wix#2625) * feat: add prop onValidateFailed to TextField (wix#2626) * feat: add prop onValidateFailed to TextField * code-review * Fix prReleaseNotesCommon file type * Fixed TabBar scroll when there is selected index (wix#2630) * Incubator.TextField - expose retainValidationSpace (wix#2631) * Add "light-date" to demo's dependencies * Incubator.Slider - fix gap not equal on both max and min ends (wix#2634) * SegmentedControl - onChangeIndex should react to changes (wix#2637) * ExpandableOverlay - add migrateDialog (wix#2635) * textField centerd style dependes on fieldState.value * TextField inputStyle hasValue refactor * webDemo react-native-gesture-handler version upgrade (wix#2647) * ColorPicker - small fixes (wix#2650) * webDemo reanimated version upgrade to 3 (wix#2649) * NumberInput - fix design (MaskedInput look) (wix#2645) * NumberInput - fix design (MaskedInput look) * Fix some types and the API * Remove getInitialData and parsePastedData * Remove Clipboard dependency * Remove decimal separator from input (not from initial) * Fix (most) tests and package.json * Remove unused prop * Support validateOnBlur * Add textStyle * Add factor * Fix * Add Incubator.Slider driver (wix#2629) * Feat/color picker add full color to result (wix#2651) * ColorPicker - small fixes * ColorSwatch - refactor result * Add hexString * Rename to value * Rename to value 2 * Rename to ColorInfo * Infra/ remove useCustomTheme leftovers (wix#2666) * feat: [MAW-257] svgImage support tintColor on web (wix#2667) * feat: [MAW-257] svgImage support tintColor on web * use StyleSheet.flatten * Picker fix for validateForm (wix#2661) * NumberInput - fix editable (wix#2664) * Picker example for the webDemo (wix#2622) * Picker exmaple for the webDemo * new picker dialog example * Fix svg example * fixed review comments --------- Co-authored-by: lidord-wix <lidord@wix.com> * testkit - new iteration (wix#2655) * testkit - new iteration * Minor improvements * Add DEFAULT_LIST_ITEM_HEIGHT and SortableListDriver * Flatten actions * NumberInput - support focus (wix#2671) * NumberInput - support focus * Add focus color and fix screen onBlur * feat/enhance text highlight string (wix#2663) * extended the `Text` component `highlightString` prop, to allow it to also receive a `HighlightStringProps` object (or an array of such objects) that enables the user to handle a highlight string `onPress` event, provide a style per highlight string and give it a `testID` for testing * fix lint warning * fix docs * review fixes * Scheme - fix color changing (wix#2607) * Scheme - fix flickering * Update src/commons/asBaseComponent.tsx Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com> --------- Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com> * Text - default alignment (wix#2670) * Text - removing default text alignment (set to left) to allow children to get parent alignment (issue is on iOS only) * update snapshot tests - Button, AvatarScreen * Replacing default textAlign with writingDirection to fix rtl * Adding writingDirectionTypes and updating snapshot tests * adding comment * ExpandableOverlay - fix dialog props (wix#2675) * Picker migrate Dialog (wix#2657) * Picker migrate Dialog * exported close expandable function * removed dialogProps prop from types file * added bak the native picker example * fixed the ts error on ExpandableOverlay dialogProps in Picker. (wix#2677) * fixed the ts error on ExpandableOverlay dailogProps in Picker. * removed the migrateDialog prop * declare other global typings (wix#2678) * declare other global typings * Cleanup old typings * Create common typings and fix import paths * Remove old typings folder * Remove measureme typings * Move fsTagName global interface to recorderType file * fix: Picker label not updating when items prop changes (wix#2682) * change margin to padding (wix#2683) * ScrollBar - fix scrolling inside Dialog on Android (wix#2695) * use ScrollView and FlatList from gesture-handler * formatting * Android build - fix kotlin version * Performance - remove keys, simplify isSameDay + prettify * Performance - simplify isSameMonth + add some types + prettify * Remove logs from tests * Week - reducing lodash import * Removing isToday() tool * fix bg logic * Performance - isPastDate * Performance - isPastDate - revert * Header - adding throttle to arrow press * Refactor Day component to not use animated styles (wix#2698) * Refactor Day component to not use animated styles * Remove unnecessary null check * Calendar - fix extra space at the bottom * Fix initialization of calendar items to not be called more than once * Enable Calendar agenda in example screen * Fix tests' TS * Header - fix non-static header title * Update calendars mocks * Agenda - refactor * Header - fix initial title * View - add reanimated props for layout animation (wix#2694) * No static locale infra (wix#2684) * CalendarItem - fix default height * Demo - adding RTL screen (wix#2668) * Text - revert Android alignment (wix#2701) * Revert "No static locale infra (wix#2684)" (wix#2702) This reverts commit 295e12e. * ColorPicker - allow theme (wix#2704) * ColorPicker - allow theme * Add props Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com> --------- Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com> * Slider - fix value out of range warning in range slider (wix#2709) * Add key to BadgeProps (wix#2689) * wheel picker onlayout fix (wix#2705) * wheel picker onlayout fix * removed comments * limit picker number of lines (wix#2712) * Expose TypographyKeys (wix#2715) * Fix RTL on Android (wix#2717) * Fix picked reanimated typings (wix#2726) * remove ThemeComponent leftovers (wix#2719) * Picker modal list testID (wix#2723) * add testID for picker modal list * add testID for picker modal list * add testID for picker modal list * fix lint * fix: [WEB] SvgImage update styles (wix#2728) * fix: [WEB] SvgImage update styles * fix sizing of svg wrapper * code review --------- Co-authored-by: Inbal Tish <inbalti@wix.com> Co-authored-by: Miki Leib <38354019+M-i-k-e-l@users.noreply.github.com> Co-authored-by: Adi Mordo <adids1221@gmail.com> Co-authored-by: Inbal Tish <33805983+Inbal-Tish@users.noreply.github.com> Co-authored-by: Ethan Sharabi <1780255+ethanshar@users.noreply.github.com> Co-authored-by: Lidor Dafna <66782556+lidord-wix@users.noreply.github.com> Co-authored-by: M-i-k-e-l <michaelle@wix.com> Co-authored-by: Amit Shwarts <amitshw@wix.com> Co-authored-by: lidord-wix <lidord@wix.com> Co-authored-by: Oren Zakay <orenz@wix.com> Co-authored-by: israelko <85411297+israelko@users.noreply.github.com> Co-authored-by: Liat Netach <60575762+liatnetach@users.noreply.github.com> Co-authored-by: yuvalsho <49347352+yuvalsho@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Text - remove default textAlign style to fix iOS child Text not inheriting from its parent.
⚠️ Note: on Android, the Text will not align to the right on RTL if the actual language is not RTL language (back to its default behavior in RN)
Changelog
Text - remove default textAlign style to fix iOS child Text not inheriting from its parent.
Additional info
Solves #2457