Feat/incubator text field preset #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendyEdri
reviewed
Jan 3, 2021
| /** | ||
| * Predefined preset to use for styling the field | ||
| */ | ||
| preset?: 'default' | undefined; |
There was a problem hiding this comment.
Would the type be optional boolean?
(useDefaultPreset for example)
There was a problem hiding this comment.
Actually the idea was to add more presets in the future, so the preset prop was meant to be used as an enum.
For now I just added the default preset so it feels redundant..
There was a problem hiding this comment.
Yeah that's what I thought it meant to be, merging
mendyEdri
reviewed
Jan 3, 2021
mendyEdri
approved these changes
Jan 3, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 3, 2021
…-logic * master: Fix lint error cleanup eslintrc file Infra/useDidUpdate (#1112) Support UI presets for Incubator.TextField and set a 'default' preset (#1111) Fix lint issues fix radioButton lint errors and generate types Fix/imageSource deprecation (#1115) Typescript/tab controller move to function component (#1098) Feat/radio button customize styling (#1092) bug fixes for TabBar refactor (#1106) Update ios target to 11 prettify file Fix icon size in badges example screen (#1104) icon prop - fix type to be both number and object. (#1086) enable eslint on both ts and js files (#1101) fix eslint (#1107) # Conflicts: # demo/src/screens/componentScreens/FaderScreen.tsx # src/components/fader/index.tsx # src/components/tabController/FadedScrollView.tsx # src/components/tabController/TabBar.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support
presetprop in the new TextField component and add the first "default" preset.This should keep parity with the old TextField UI but still allows to keep the UI code separated
Changelog
Support "default" preset to our Incubator.TextField component