Infra/useDidUpdate #1112
Merged
Infra/useDidUpdate #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanshar
reviewed
Jan 3, 2021
src/hooks/useDidUpdate/index.ts
Outdated
Comment on lines
10
to
12
| const isDataChanged = useCallback(() => { | ||
| return !_.isEqual(_dep.current, dep); | ||
| }, [dep]); |
There was a problem hiding this comment.
Not sure there's a need for useCallback here, you don't pass the function reference anywhere..
There was a problem hiding this comment.
Right, I should change it to useMemo to avoid re do the _. isEqual work
| return !_.isEqual(_dep.current, dep); | ||
| }, [dep]); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Maybe im missing something..
shouldn't there be a code that prevents from this effect to trigger on initial mount?
There was a problem hiding this comment.
Since the inner dependancies set to be as the passed prop dependancies, it will actually start as the same value..
ethanshar
approved these changes
Jan 3, 2021
M-i-k-e-l
added a commit
that referenced
this pull request
Jan 3, 2021
…-logic * master: Fix lint error cleanup eslintrc file Infra/useDidUpdate (#1112) Support UI presets for Incubator.TextField and set a 'default' preset (#1111) Fix lint issues fix radioButton lint errors and generate types Fix/imageSource deprecation (#1115) Typescript/tab controller move to function component (#1098) Feat/radio button customize styling (#1092) bug fixes for TabBar refactor (#1106) Update ios target to 11 prettify file Fix icon size in badges example screen (#1104) icon prop - fix type to be both number and object. (#1086) enable eslint on both ts and js files (#1101) fix eslint (#1107) # Conflicts: # demo/src/screens/componentScreens/FaderScreen.tsx # src/components/fader/index.tsx # src/components/tabController/FadedScrollView.tsx # src/components/tabController/TabBar.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new hook tool - useDidUpdate to avoid getting side effect calls on initial value.
Changelog
Introduce new useDidUpdate hook, that will skip update on initial value.