Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #138, #139, #134, #144, #145, #147, #157, #158, #161, #162 #142

Merged
merged 16 commits into from
Jul 6, 2016
Merged

Fix #138, #139, #134, #144, #145, #147, #157, #158, #161, #162 #142

merged 16 commits into from
Jul 6, 2016

Conversation

nippur72
Copy link
Contributor

@nippur72 nippur72 commented Jun 4, 2016

This PR checks that rt-template has a single child element. Previously no warning were given and only the first element was considered.

It also fixes #138 when the child element is text element.

@nippur72 nippur72 changed the title Single child for rt-template (fixes #138) Fix for #138 and #139 Jun 5, 2016
@nippur72
Copy link
Contributor Author

nippur72 commented Jun 5, 2016

Update: this PR fixes also issue #139 by which scoped function do not see props and context argument from render (when stateless).

The solution was to make scoped functions nested within the main render.

The internal use of lodash templates (<% %>) has been simplified too, as well as rendering for the JSRT case.

I've changed the tests accordingly.

As a further test, I've tried it with a large app of mine and all seems ok.

@nippur72
Copy link
Contributor Author

nippur72 commented Jun 5, 2016

Update 2: fixing also #134

@nippur72 nippur72 changed the title Fix for #138 and #139 Fix for #138, #139 and #134 Jun 5, 2016
@nippur72
Copy link
Contributor Author

nippur72 commented Jun 6, 2016

This now fixes also #144 and #145

@nippur72 nippur72 changed the title Fix for #138, #139 and #134 Fix for #138, #139, #134, #144, #145 Jun 6, 2016
@nippur72 nippur72 changed the title Fix for #138, #139, #134, #144, #145 Fix #138, #139, #134, #144, #145, #147 Jun 8, 2016
@nippur72
Copy link
Contributor Author

nippur72 commented Jun 8, 2016

This now fixes also #147.

@nippur72
Copy link
Contributor Author

nippur72 commented Jun 8, 2016

I think I'm done with bug fixing, so please @ganimomer | @idok can review this PR?

@nippur72
Copy link
Contributor Author

Added fix for #157 and #158 too.

#157: comments are turned off if modules is es6.

#158: replaced comment text */ with * /

@nippur72 nippur72 changed the title Fix #138, #139, #134, #144, #145, #147 Fix #138, #139, #134, #144, #145, #147, #157, #158 Jun 20, 2016
@nippur72 nippur72 changed the title Fix #138, #139, #134, #144, #145, #147, #157, #158 Fix #138, #139, #134, #144, #145, #147, #157, #158, #161 Jun 22, 2016
@nippur72
Copy link
Contributor Author

fixing also #162

@nippur72 nippur72 changed the title Fix #138, #139, #134, #144, #145, #147, #157, #158, #161 Fix #138, #139, #134, #144, #145, #147, #157, #158, #161, #162 Jun 23, 2016
@idok idok merged commit 46caeea into wix-incubator:gh-pages Jul 6, 2016
@nippur72 nippur72 deleted the rt-template-child-no-text branch July 6, 2016 14:32
@nippur72 nippur72 mentioned this pull request Aug 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nippur72 @idok