-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#175, #179, #135, #93, #183, #184, #191, fix broken html tests, fix broken --react-import-path #176
base: gh-pages
Are you sure you want to change the base?
Conversation
Fixed html tests that were not running due to changed file name. Failing html tests now dump "actual" html instead of the code that generates it (.actual.html) Fixed title for rtStyle tests Removed compareAndWriteHtml() that is no longer needed
rt-scope syntax parser now is able to scan over quoted strings (both single and double quotes) which may be also contain escaped quotes (\" or \')
With the latest commits:
|
This PR now implements also #135 with the new (optional) CLI option If an alias is specified, it will be used in place of Example of 'use strict';
var h = require('react').createElement;
var _ = require('lodash');
module.exports = function () {
return h('div', {}, h('span', {}, 'Hello'));
}; |
This PR now fixes also an issue with Regarding the
will generate: var h = require('preact').h;
module.exports = function () {
return h('div', {}, h('span', {}, 'Hello'));
}; |
* new CLI option --external-helpers * lodash is now loaded only if required
this PR now fixes also #190 |
...and #191 |
Hi nino, |
sure, I will split it into as small as possible PRs, though it might take a while since I have to do some reconciliation |
This PR improves the parser for
rt-scope
as discussed in #175.It's based on a regex, the improvement comes from scanning for
as identifier;
instead of just;
thus lowering the chances of picking a semicolon in the wrong place.Of course there are still failing cases, but they are much less.
With this PR the following can be now parsed: