Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small mistake in the regexp for validate_alpha_dash and validate_valid_name #7

Closed
ben-s opened this issue Jan 18, 2012 · 1 comment
Closed

Comments

@ben-s
Copy link

ben-s commented Jan 18, 2012

Hi,
In the corrections you made yesterday, I can see a small mistake in the regexp for both methods validate_valid_name and validate_alpha :
if(!preg_match("/^([-a-z0-9ÀÁÂÃÄÅÇÈÉÊËÌÍÎÏÒÓÔÕÖÙÚÛÜÝàáâãäåçèéêëìíîïðòóôõöùúûüýÿ_-])+$/i", $input[$field]) !== FALSE)

As you can see, the first dash is unseless since it is given at the end of the regexp.

@sn
Copy link
Member

sn commented Jan 20, 2012

Thanks for picking that up, Ben.

I've fixed it in: http://github.com/Wixel/GUMP/commit/67f1120cce361e113cc0cdd005cb1d36dbf64c00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants