-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ParseTypeLibElement MinorVersion maximum value check #4726
Comments
|
https://msdn.microsoft.com/en-us/library/aa372092%28v=vs.85%29.aspx says Version
which explains the current implementation. Recommend wontfix.
|
Non-advertised should support 16-bit range. Advertised cannot.
|
I'm looking at this issue. I think I can fix the bug, but I don't know where to put failing test(s) for Compiler.Package or Compiler. Ron |
Compiler tests mostly live here: https://github.com/wixtoolset/wix4/tree/develop/src/wix/test/WixToolsetTest.CoreIntegration |
I'll take a look at your pull request. |
Thanks!
…On 6/10/2021 2:10 PM, Bob Arnson wrote:
I'll take a look at your pull request.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#4726 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHIYUBRBMWNXSH2WBPXWCHTTSD52JANCNFSM45L5SQIA>.
|
Hi,
I noticed in ParseTypeLibElement, WIX uses byte.MaxValue to check the range, however from Microsoft, minor version can be a 16bit value which is the same as MajorVersion
minor-value
Specifies a short unsigned integer between zero and 65,535
I assume it needs to be changed to ushort.MaxValue?
https://msdn.microsoft.com/en-us/library/windows/desktop/aa367306(v=vs.85).aspx
minorVersion = this.core.GetAttributeIntegerValue(sourceLineNumbers, attrib, 0, byte.MaxValue);
Thanks
Jim
The text was updated successfully, but these errors were encountered: