Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Copy and modify" instructions not working for WixUI_Advanced and WixUI_Minimal #6805

Closed
JVimes opened this issue Jun 10, 2022 · 2 comments · Fixed by wixtoolset/web#180
Closed
Assignees
Milestone

Comments

@JVimes
Copy link

JVimes commented Jun 10, 2022

Bugs

  • Which version of WiX are you building with?

3.11.2

  • Which version of Visual Studio are you building with (if any)?

Community 2022 (64-bit) 17.3.0 Preview 1.1

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

None

  • Which version of .NET are you building with?

.NET Framework 4.8

Describe the problem and the steps to reproduce it.

I'm trying to follow the instructions in Customizing Built-in WixUI Dialog Sets:

...copy the contents of the <Fragment/> that includes the definition of the dialog set that you want to customize from the WiX source code to your project. Then, you must modify...

This only seems to work for WixUI_FeatureTree, WixUI_InstallDir, and WixUI_Mondo.

For WixUI_Advanced and WixUI_Minimal, my build gives several "LGHT0091 Duplicate symbol" errors.

Here's my Product.wxs, for reference.

@JVimes JVimes added the triage label Jun 10, 2022
@barnson barnson added this to the v4.x milestone Jun 23, 2022
@barnson barnson self-assigned this Jun 23, 2022
@barnson
Copy link
Member

barnson commented Jun 23, 2022

You need to rename the UI/@Id so it isn't the same as the original.

@JVimes
Copy link
Author

JVimes commented Jun 23, 2022

Thank you. I don't think I see that in the docs, so the problem may be that the docs are out of sync with the product. I didn't have to change an ID for feature tree, install dir, and mondo UIs.

barnson added a commit to wixtoolset/web that referenced this issue Mar 14, 2023
barnson added a commit to wixtoolset/web that referenced this issue Mar 14, 2023
@robmen robmen modified the milestones: v4.x, Web Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants