Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle without BootstrapperApplication fails with message from exception #6852

Closed
robmen opened this issue Aug 5, 2022 · 3 comments · Fixed by wixtoolset/wix#224
Closed
Assignees
Labels
Milestone

Comments

@robmen
Copy link
Member

robmen commented Aug 5, 2022

Encountered at: wixtoolset/wix@16ed873f

Detail:

Currently BindBundleCommand expects that a single WixBoostrapperApplicationDllSymbol is enforced by the compiler. If not, binding throws an exception not intended for the user: error WIX341: The Bundle is missing 'T' data, and cannot continue.

However, the following code will get by the compiler:

<Wix xmlns="http://wixtoolset.org/schemas/v4/wxs">
  <Bundle Version="1.0.0" UpgradeCode="USE-A-REAL-G-U-I-D">

    <Chain>
      <MsiPackage SourceFile="path\to\a.msi" />
    </Chain>
  </Bundle>
</Wix>

A missing Chain element is caught by the compiler, so I think the fix is for the same check to happen for the bootstrapper application in the compiler, but I'm not sure thus this issue.

@robmen robmen added the triage label Aug 5, 2022
@barnson
Copy link
Member

barnson commented Aug 5, 2022

See #6305.

@robmen
Copy link
Member Author

robmen commented Aug 5, 2022

PS: I have a commit local to improve the exception message, but that will only "help" WiX devs, not end users.

@rseanhall
Copy link
Contributor

The WixBootstrapperApplicationDllSymbol will almost always come from Bal.wixext so unlike the chain this can't be done in the compiler. We have a very similar problem with the package payload symbols (for example ExePackagePayload) which is caught in GetPackageFacadesCommand.

@barnson barnson self-assigned this Aug 11, 2022
@barnson barnson added linker and removed triage labels Aug 11, 2022
@barnson barnson added this to the v4.0 milestone Aug 11, 2022
barnson added a commit to wixtoolset/wix that referenced this issue Aug 15, 2022
barnson added a commit to wixtoolset/wix that referenced this issue Aug 15, 2022
barnson added a commit to wixtoolset/wix that referenced this issue Aug 16, 2022
rseanhall pushed a commit to rseanhall/wix4 that referenced this issue Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants