Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error messages aren't correctly sent (logged) (displayed) (processed) #7444

Closed
barnson opened this issue Apr 24, 2023 · 2 comments · Fixed by wixtoolset/wix#402
Closed

Error messages aren't correctly sent (logged) (displayed) (processed) #7444

barnson opened this issue Apr 24, 2023 · 2 comments · Fixed by wixtoolset/wix#402
Assignees
@barnson
Labels
nativesdk
Milestone
v4.0.1

Comments

@barnson
Copy link
Member

barnson commented Apr 24, 2023

  • Which version of WiX are you building with?

v4.0.0

  • Which version of Visual Studio are you building with (if any)?

17.5.4

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

n/a

  • Which version of .NET are you building with?

4.8.1

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?
  • Describe the problem and the steps to reproduce it.

Error messages from standard custom actions sent via WcaErrorMessage are no longer correctly processed. Instead, you'll get

ExecXmlConfig:  Error 0x80070057: failed to set hresult code into error message
  • Describe the behavior you expected and how it differed from the actual behavior.

The error should be logged and, in full UI, displayed via message box.
@barnson barnson added the triage label Apr 24, 2023
@barnson
Copy link
Member Author

barnson commented Apr 25, 2023

See also #7422.

barnson added a commit to wixtoolset/wix that referenced this issue Apr 25, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
5460ccc 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
@barnson barnson mentioned this issue Apr 25, 2023
Merged
barnson added a commit to wixtoolset/wix that referenced this issue Apr 25, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
b1f5b44 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 25, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
3298b9a 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 25, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
7a680ac 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 25, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
fd96523 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 26, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
0e45143 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 26, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
6dd99ee 
Count args before creating message record.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 27, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
6b36a89 
- Count args before creating message record.
- Document terminating NULL requirement.
- Add terminating NULL in MessageExit* macros.
- Enhance tests for problems encountered fixing this nightmare.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 27, 2023
@barnson
Fix WcaErrorMessage cArgs==-1 case.
b3b9dec 
- Count args before creating message record.
- Document terminating NULL requirement.
- Add terminating NULL in MessageExit* macros.
- Enhance tests for problems encountered fixing this nightmare.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
@barnson
Copy link
Member Author

barnson commented Apr 27, 2023

Reopen for triage.

@barnson barnson reopened this Apr 27, 2023
barnson added a commit to wixtoolset/wix that referenced this issue Apr 28, 2023
@barnson
Fix XmlConfig lookup logic.
cc791e3 
Fixes wixtoolset/issues#7377.
Requires fix for wixtoolset/issues#7444.
@barnson barnson mentioned this issue Apr 28, 2023
Merged
barnson added a commit to wixtoolset/wix that referenced this issue Apr 28, 2023
@barnson
Fix XmlConfig lookup logic.
0276055 
Fixes wixtoolset/issues#7377.
Requires fix for wixtoolset/issues#7444.
barnson added a commit to wixtoolset/wix that referenced this issue Apr 28, 2023
@barnson
Fix XmlConfig lookup logic.
ab8d368 
Fixes wixtoolset/issues#7377.
Requires fix for wixtoolset/issues#7444.
@barnson barnson self-assigned this May 2, 2023
@barnson barnson added nativesdk and removed triage labels May 2, 2023
@barnson barnson added this to the v4.0.1 milestone May 2, 2023
@barnson barnson closed this as completed May 2, 2023
robmen pushed a commit to wixtoolset/wix that referenced this issue Jun 3, 2023
@barnson @robmen
Fix WcaErrorMessage cArgs==-1 case.
fe57e71 
- Count args before creating message record.
- Document terminating NULL requirement.
- Add terminating NULL in MessageExit* macros.
- Enhance tests for problems encountered fixing this nightmare.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
robmen pushed a commit to wixtoolset/wix that referenced this issue Jun 3, 2023
@barnson @robmen
Fix XmlConfig lookup logic.
e1aeeae 
Fixes wixtoolset/issues#7377.
Requires fix for wixtoolset/issues#7444.
robmen pushed a commit to wixtoolset/wix that referenced this issue Jun 3, 2023
@barnson @robmen
Fix WcaErrorMessage cArgs==-1 case.
1da29b4 
- Count args before creating message record.
- Document terminating NULL requirement.
- Add terminating NULL in MessageExit* macros.
- Enhance tests for problems encountered fixing this nightmare.

Fixes wixtoolset/issues#7422.
Fixes wixtoolset/issues#7444.
robmen pushed a commit to wixtoolset/wix that referenced this issue Jun 3, 2023
@barnson @robmen
Fix XmlConfig lookup logic.
1d7ca4c 
Fixes wixtoolset/issues#7377.
Requires fix for wixtoolset/issues#7444.
solidstore added a commit to solidstore/wix that referenced this issue Aug 10, 2023
@solidstore
Squashed commit of the following:
4467e7f 
commit 320db2b
Merge: 5bf3981 59f37d2
Author: Ryan Stevens <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 10 07:53:33 2023 +0100

    Merge branch 'wixtoolset:develop' into develop

commit 5bf3981
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 10 07:51:33 2023 +0100

    tidy

commit 5cef22f
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Aug 9 14:51:26 2023 +0100

    Delete WixHttpSslCertSymbol.cs

commit 915c08d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Aug 9 14:01:46 2023 +0100

    SSL bindings latest

commit 451ba3c
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Mon Aug 7 15:24:02 2023 +0100

    Bindings refactor

commit f646f02
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 3 08:47:41 2023 +0100

    renaming Certificate fields

commit 0be5144
Merge: cef14c6 dad178d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 3 07:51:38 2023 +0100

    Merge branch 'develop402' into develop

commit dad178d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Jul 19 10:12:27 2023 +0100

    CertificateRef support

commit 2f42efa
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Tue Jul 18 11:21:21 2023 +0100

    SetSslCertSetKey fixes

commit 1a4fabf
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Mon Jul 17 13:58:11 2023 +0100

    HTTP_SERVICE_CONFIG_SSL_SET support

commit 3d9737d
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 22dadea
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ed2a8d1
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 140abaa
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Jun 21 19:53:56 2023 -0400

    Start WiX Toolset v4.0.2.

commit 6e6eb47
Author: Rob Mensching <rob@firegiant.com>
Date:   Sun Jun 4 10:47:29 2023 -0700

    WiX Toolset v4.0.1

commit e25aa43
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit 29cec14
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit 856658a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399

commit 36e3408
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon May 22 09:47:17 2023 -0700

    Update CLA signatures location

commit ddc7997
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 17 18:14:59 2023 -0400

    Fix duplicate keys from inline subdirectories.

    Fixes wixtoolset/issues#7459.

commit 1da042f
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon May 15 21:05:50 2023 -0400

    Skip processing missing FeatureComponents table.

    Fixes wixtoolset/issues#7472.

commit 5ddb81c
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 11 22:57:46 2023 -0400

    Fix Dialog table decompilation.

    Fix duplicate NoMinimize attribute and
    add attributes that were entirely missing.

    Fixes wixtoolset/issues#7482.

commit f86155f
Author: timberto <33670243+timberto@users.noreply.github.com>
Date:   Tue Apr 18 12:34:25 2023 +0200

    Show correct error message when upgrade is blocked

commit 13dbe58
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue May 2 20:39:26 2023 -0400

    Fix Msmq key table relationship.

    Fixes wixtoolset/issues#7454.

commit 0844d65
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Sun Apr 23 07:55:21 2023 +0300

    Fix build failure when bundle has multiple RemoteBundle elements

commit 9b78fdf
Author: fyodorkor <fyodorkor@gmail.com>
Date:   Thu Apr 13 22:37:02 2023 +0300

    Fix XmlConfig decompile to produce schema element, Add unitest for XmlDecomile

commit 5520259
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon May 1 21:09:14 2023 -0400

    Tame some wild pointers.

    Maybe Rust wouldn't be so bad...

    Fixes wixtoolset/issues#7451.

commit 1d7ca4c
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 27 21:06:35 2023 -0400

    Fix XmlConfig lookup logic.

    Fixes wixtoolset/issues#7377.
    Requires fix for wixtoolset/issues#7444.

commit 1da29b4
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Apr 24 22:16:34 2023 -0400

    Fix WcaErrorMessage `cArgs==-1` case.

    - Count args before creating message record.
    - Document terminating NULL requirement.
    - Add terminating NULL in MessageExit* macros.
    - Enhance tests for problems encountered fixing this nightmare.

    Fixes wixtoolset/issues#7422.
    Fixes wixtoolset/issues#7444.

commit 2914646
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Apr 26 13:33:59 2023 -0400

    Remove InstallDirDlg reference from WixUI_Mondo

    Fixes wixtoolset/issues#7436.

commit 8461656
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 20 18:23:07 2023 -0400

    Fix merged ProductCode from mergemod.cub and...

    ...work around other bugs in mergemod.cub.

    Fixes wixtoolset/issues#7413.

commit 005a33a
Author: Mike Wileczka <22036740+mwileczka@users.noreply.github.com>
Date:   Wed Apr 19 10:12:24 2023 -0400

    Fix harvesting project names with invalid chars

    Project names with invalid characters, namely spaces, where not being harvested properly. The sanitized name is requires for the `Source="$(var.PROJECT_NAME` output. Updated harvest project unit test for project names with spaces.

commit b4fe940
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Apr 18 09:02:59 2023 -0700

    Do not crash on Subdirectory when missing Component Directory attribute

    Fixes 7407

commit 2fa6703
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Apr 18 08:43:26 2023 -0700

    Allow "." as valid Directory SourceName

    Fixes 7384

commit 6d2fa6a
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 22:55:23 2023 -0700

    Start WiX Toolset v4.0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barnson barnson

Labels
nativesdk
Projects
None yet
Milestone
v4.0.1
Development

Successfully merging a pull request may close this issue.

Fix WcaErrorMessage cArgs==-1 case. wixtoolset/wix
1 participant
@barnson