Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge modules don't extract during decompilation #7568

Closed
barnson opened this issue Jun 20, 2023 · 0 comments · Fixed by wixtoolset/wix#422
Closed

Merge modules don't extract during decompilation #7568

barnson opened this issue Jun 20, 2023 · 0 comments · Fixed by wixtoolset/wix#422
Assignees
@barnson
Labels
decompiler
Milestone
v4.0.2

Comments

@barnson
Copy link
Member

barnson commented Jun 20, 2023

  • Which version of WiX are you building with?

v4.0.1 & HEAD

  • Which version of Visual Studio are you building with (if any)?

v17.6.3

  • Which version of the WiX Toolset Visual Studio Extension are you building with (if any)?

n/a

  • Which version of .NET are you building with?

v4.8.1

  • If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

n/a

  • Describe the problem and the steps to reproduce it.

wix msi decompile -x out mod.msm does not extract any files.

  • Describe the behavior you expected and how it differed from the actual behavior.

wix msi decompile -x out mod.msm should extract many files.
@barnson barnson added the triage label Jun 20, 2023
barnson added a commit to wixtoolset/wix that referenced this issue Jun 21, 2023
@barnson
Handle MergeModule.CABinet for extraction.
7d1fd39 
Fixes wixtoolset/issues#7568,
@barnson barnson mentioned this issue Jun 21, 2023
Merged
barnson added a commit to wixtoolset/wix that referenced this issue Jun 21, 2023
@barnson
Handle MergeModule.CABinet for extraction.
80f8fc2 
Fixes wixtoolset/issues#7568,
barnson added a commit to wixtoolset/wix that referenced this issue Jun 21, 2023
@barnson
Handle MergeModule.CABinet for extraction.
ddae99c 
Fixes wixtoolset/issues#7568,
@barnson barnson reopened this Jun 21, 2023
barnson added a commit to wixtoolset/wix that referenced this issue Jun 21, 2023
@barnson
Handle MergeModule.CABinet for extraction.
3d5dc76 
Fixes wixtoolset/issues#7568,
barnson added a commit to wixtoolset/wix that referenced this issue Jun 22, 2023
@barnson
Handle MergeModule.CABinet for extraction.
ed2a8d1 
Fixes wixtoolset/issues#7568,
@barnson barnson mentioned this issue Jun 27, 2023
Closed
nirbar added a commit to nirbar/wix4 that referenced this issue Jun 27, 2023
@nirbar
Squashed commit of the following:
24cac37 
commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
@barnson barnson self-assigned this Jun 27, 2023
@barnson barnson added decompiler and removed triage labels Jun 27, 2023
@barnson barnson closed this as completed Jun 27, 2023
nirbar added a commit to nirbar/wix4 that referenced this issue Jul 6, 2023
@nirbar
Squashed commit of the following:
8f26715 
commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
@robmen robmen added this to the v4.0.2 milestone Aug 8, 2023
nirbar added a commit to nirbar/wix4 that referenced this issue Aug 9, 2023
@nirbar
Squashed commit of the following:
a42df58 
commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
nirbar added a commit to nirbar/wix4 that referenced this issue Aug 9, 2023
@nirbar
Squashed commit of the following:
c4fe327 
commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
solidstore added a commit to solidstore/wix that referenced this issue Aug 10, 2023
@solidstore
Squashed commit of the following:
4467e7f 
commit 320db2b
Merge: 5bf3981 59f37d2
Author: Ryan Stevens <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 10 07:53:33 2023 +0100

    Merge branch 'wixtoolset:develop' into develop

commit 5bf3981
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 10 07:51:33 2023 +0100

    tidy

commit 5cef22f
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Aug 9 14:51:26 2023 +0100

    Delete WixHttpSslCertSymbol.cs

commit 915c08d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Aug 9 14:01:46 2023 +0100

    SSL bindings latest

commit 451ba3c
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Mon Aug 7 15:24:02 2023 +0100

    Bindings refactor

commit f646f02
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 3 08:47:41 2023 +0100

    renaming Certificate fields

commit 0be5144
Merge: cef14c6 dad178d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Thu Aug 3 07:51:38 2023 +0100

    Merge branch 'develop402' into develop

commit dad178d
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Wed Jul 19 10:12:27 2023 +0100

    CertificateRef support

commit 2f42efa
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Tue Jul 18 11:21:21 2023 +0100

    SetSslCertSetKey fixes

commit 1a4fabf
Author: solidstore <ryan.stevens@solidstore.co.uk>
Date:   Mon Jul 17 13:58:11 2023 +0100

    HTTP_SERVICE_CONFIG_SSL_SET support

commit 3d9737d
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 22dadea
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ed2a8d1
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 140abaa
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Jun 21 19:53:56 2023 -0400

    Start WiX Toolset v4.0.2.

commit 6e6eb47
Author: Rob Mensching <rob@firegiant.com>
Date:   Sun Jun 4 10:47:29 2023 -0700

    WiX Toolset v4.0.1

commit e25aa43
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit 29cec14
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit 856658a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399

commit 36e3408
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon May 22 09:47:17 2023 -0700

    Update CLA signatures location

commit ddc7997
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 17 18:14:59 2023 -0400

    Fix duplicate keys from inline subdirectories.

    Fixes wixtoolset/issues#7459.

commit 1da042f
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon May 15 21:05:50 2023 -0400

    Skip processing missing FeatureComponents table.

    Fixes wixtoolset/issues#7472.

commit 5ddb81c
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 11 22:57:46 2023 -0400

    Fix Dialog table decompilation.

    Fix duplicate NoMinimize attribute and
    add attributes that were entirely missing.

    Fixes wixtoolset/issues#7482.

commit f86155f
Author: timberto <33670243+timberto@users.noreply.github.com>
Date:   Tue Apr 18 12:34:25 2023 +0200

    Show correct error message when upgrade is blocked

commit 13dbe58
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue May 2 20:39:26 2023 -0400

    Fix Msmq key table relationship.

    Fixes wixtoolset/issues#7454.

commit 0844d65
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Sun Apr 23 07:55:21 2023 +0300

    Fix build failure when bundle has multiple RemoteBundle elements

commit 9b78fdf
Author: fyodorkor <fyodorkor@gmail.com>
Date:   Thu Apr 13 22:37:02 2023 +0300

    Fix XmlConfig decompile to produce schema element, Add unitest for XmlDecomile

commit 5520259
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon May 1 21:09:14 2023 -0400

    Tame some wild pointers.

    Maybe Rust wouldn't be so bad...

    Fixes wixtoolset/issues#7451.

commit 1d7ca4c
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 27 21:06:35 2023 -0400

    Fix XmlConfig lookup logic.

    Fixes wixtoolset/issues#7377.
    Requires fix for wixtoolset/issues#7444.

commit 1da29b4
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Apr 24 22:16:34 2023 -0400

    Fix WcaErrorMessage `cArgs==-1` case.

    - Count args before creating message record.
    - Document terminating NULL requirement.
    - Add terminating NULL in MessageExit* macros.
    - Enhance tests for problems encountered fixing this nightmare.

    Fixes wixtoolset/issues#7422.
    Fixes wixtoolset/issues#7444.

commit 2914646
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed Apr 26 13:33:59 2023 -0400

    Remove InstallDirDlg reference from WixUI_Mondo

    Fixes wixtoolset/issues#7436.

commit 8461656
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Apr 20 18:23:07 2023 -0400

    Fix merged ProductCode from mergemod.cub and...

    ...work around other bugs in mergemod.cub.

    Fixes wixtoolset/issues#7413.

commit 005a33a
Author: Mike Wileczka <22036740+mwileczka@users.noreply.github.com>
Date:   Wed Apr 19 10:12:24 2023 -0400

    Fix harvesting project names with invalid chars

    Project names with invalid characters, namely spaces, where not being harvested properly. The sanitized name is requires for the `Source="$(var.PROJECT_NAME` output. Updated harvest project unit test for project names with spaces.

commit b4fe940
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Apr 18 09:02:59 2023 -0700

    Do not crash on Subdirectory when missing Component Directory attribute

    Fixes 7407

commit 2fa6703
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Apr 18 08:43:26 2023 -0700

    Allow "." as valid Directory SourceName

    Fixes 7384

commit 6d2fa6a
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 22:55:23 2023 -0700

    Start WiX Toolset v4.0.1
nirbar added a commit to nirbar/wix4 that referenced this issue Nov 2, 2023
@nirbar
Squashed commit of the following:
ee3747f 
commit b842027
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Oct 23 00:17:18 2023 -0400

    Introduce a new phase in the build pipeline.

    A useful point in the build pipeline is after all the files in the
    project have been compiled but before they've been linked.
    The WiX core and extensions can operate on symbols across
    the project but without operating at the source-code level.

    This phase is currently named "optimize," after a moderately-similar
    phase in other compiler architectures. The name is, for now, a stake in
    the ground and a better alternate is welcome.

commit bb691bd
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:34 2023 -0400

    Random typo fix.

commit f5e164d
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:21 2023 -0400

    Add cert and x64 tests.

commit 0014af6
Author: apacker1 <apacker1@users.noreply.github.com>
Date:   Fri Sep 22 14:41:57 2023 -0700

    DotNetCompatibilityCheck: If running NetCoreCheck.exe fails with error code ERROR_EXE_MACHINE_TYPE_MISMATCH or ERROR_BAD_EXE_FORMAT then don't abort the installation, just set the property to 13.  Fixes issue #7737

commit e570ce5
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Sep 12 14:08:34 2023 -0700

    Update to latest signing infrastructure

    Fixes 7546

commit 409d3b6
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 17:31:08 2023 +1000

    add FIREWALL_EXCEPTION_ATTRIBUTES struct

commit e7656ce
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Sep 10 22:52:33 2023 -0400

    Remove unused symbol `Version`.

commit f18d7e6
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Sep 4 23:40:46 2023 -0700

    Correctly process build -outputType switch

    Also add a few additional output types to built-in backends.

    Fixes 7708

commit e29b4aa
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Mon Aug 21 11:34:51 2023 +1000

    remove windows xp specific code from firewall extension

commit b3deb46
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 08:31:28 2023 +1000

    add firewall extension decompiler

commit 537e79d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 20 19:49:21 2023 +1000

    use WcaGetRecordFormattedString to get firewall rule description

commit febb9c9
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 13 11:34:57 2023 +1000

    add integration tests for the firewall extenstion

commit 6f520b9
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Aug 15 18:05:47 2023 -0400

    Properly fragment NetFx custom actions.

    FIxes wixtoolset/issues#7677.

commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
nirbar added a commit to nirbar/wix4 that referenced this issue Nov 21, 2023
@nirbar
Squashed commit of the following:
cf0ede6 
commit e0a9ec5
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 21:11:51 2023 -0500

    Remove the deprecated DifxApp WiX extension.

    Per
    https://wixtoolset.org/docs/releasenotes/#deprecations-and-deletions.

commit e5ed750
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 20:55:45 2023 -0500

    Clean up.

commit dfb7512
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Thu Sep 21 16:03:28 2023 +1000

    add firewall extension decompiler, make msi modifications work, add all attributes

commit 80e6047
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 18:51:38 2023 +1000

    change firewall extension table name to Wix5FirewallException

commit 6e97449
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 13 12:56:15 2023 -0800

    Return intermediate even if compiler encounters error

    Fixes 7854

commit a532341
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 21:46:30 2023 -0800

    Include duplicated inline directory symbols referenced in subsequent sections

    Due to the handling of redundant symbols, which are only used by inline directory
    syntax, the symbols were only defined in the first section encountered by the linker.
    Fix that so at most one duplicated inline directory symbol is included when
    referenced.

    Fixes 7840

commit 4b9bbae
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:45:46 2023 -0800

    Fix duplication of AdditionalOptions being added to command-line

    Fixes 7837

commit a886df0
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:36:57 2023 -0800

    Correctly handle top-level AppId element

    Fixes 7738

commit 96e9c0f
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 23:08:10 2023 -0800

    Avoid use of Encoding.WindowsCodePage

    Fixes 7612

commit b842027
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Oct 23 00:17:18 2023 -0400

    Introduce a new phase in the build pipeline.

    A useful point in the build pipeline is after all the files in the
    project have been compiled but before they've been linked.
    The WiX core and extensions can operate on symbols across
    the project but without operating at the source-code level.

    This phase is currently named "optimize," after a moderately-similar
    phase in other compiler architectures. The name is, for now, a stake in
    the ground and a better alternate is welcome.

commit bb691bd
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:34 2023 -0400

    Random typo fix.

commit f5e164d
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:21 2023 -0400

    Add cert and x64 tests.

commit 0014af6
Author: apacker1 <apacker1@users.noreply.github.com>
Date:   Fri Sep 22 14:41:57 2023 -0700

    DotNetCompatibilityCheck: If running NetCoreCheck.exe fails with error code ERROR_EXE_MACHINE_TYPE_MISMATCH or ERROR_BAD_EXE_FORMAT then don't abort the installation, just set the property to 13.  Fixes issue #7737

commit e570ce5
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Sep 12 14:08:34 2023 -0700

    Update to latest signing infrastructure

    Fixes 7546

commit 409d3b6
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 17:31:08 2023 +1000

    add FIREWALL_EXCEPTION_ATTRIBUTES struct

commit e7656ce
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Sep 10 22:52:33 2023 -0400

    Remove unused symbol `Version`.

commit f18d7e6
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Sep 4 23:40:46 2023 -0700

    Correctly process build -outputType switch

    Also add a few additional output types to built-in backends.

    Fixes 7708

commit e29b4aa
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Mon Aug 21 11:34:51 2023 +1000

    remove windows xp specific code from firewall extension

commit b3deb46
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 08:31:28 2023 +1000

    add firewall extension decompiler

commit 537e79d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 20 19:49:21 2023 +1000

    use WcaGetRecordFormattedString to get firewall rule description

commit febb9c9
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 13 11:34:57 2023 +1000

    add integration tests for the firewall extenstion

commit 6f520b9
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Aug 15 18:05:47 2023 -0400

    Properly fragment NetFx custom actions.

    FIxes wixtoolset/issues#7677.

commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
nirbar added a commit to nirbar/wix4 that referenced this issue Nov 21, 2023
@nirbar
Squashed commit of the following:
0610efe 
commit e0a9ec5
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 21:11:51 2023 -0500

    Remove the deprecated DifxApp WiX extension.

    Per
    https://wixtoolset.org/docs/releasenotes/#deprecations-and-deletions.

commit e5ed750
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 20:55:45 2023 -0500

    Clean up.

commit dfb7512
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Thu Sep 21 16:03:28 2023 +1000

    add firewall extension decompiler, make msi modifications work, add all attributes

commit 80e6047
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 18:51:38 2023 +1000

    change firewall extension table name to Wix5FirewallException

commit 6e97449
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 13 12:56:15 2023 -0800

    Return intermediate even if compiler encounters error

    Fixes 7854

commit a532341
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 21:46:30 2023 -0800

    Include duplicated inline directory symbols referenced in subsequent sections

    Due to the handling of redundant symbols, which are only used by inline directory
    syntax, the symbols were only defined in the first section encountered by the linker.
    Fix that so at most one duplicated inline directory symbol is included when
    referenced.

    Fixes 7840

commit 4b9bbae
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:45:46 2023 -0800

    Fix duplication of AdditionalOptions being added to command-line

    Fixes 7837

commit a886df0
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:36:57 2023 -0800

    Correctly handle top-level AppId element

    Fixes 7738

commit 96e9c0f
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 23:08:10 2023 -0800

    Avoid use of Encoding.WindowsCodePage

    Fixes 7612

commit b842027
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Oct 23 00:17:18 2023 -0400

    Introduce a new phase in the build pipeline.

    A useful point in the build pipeline is after all the files in the
    project have been compiled but before they've been linked.
    The WiX core and extensions can operate on symbols across
    the project but without operating at the source-code level.

    This phase is currently named "optimize," after a moderately-similar
    phase in other compiler architectures. The name is, for now, a stake in
    the ground and a better alternate is welcome.

commit bb691bd
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:34 2023 -0400

    Random typo fix.

commit f5e164d
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:21 2023 -0400

    Add cert and x64 tests.

commit 0014af6
Author: apacker1 <apacker1@users.noreply.github.com>
Date:   Fri Sep 22 14:41:57 2023 -0700

    DotNetCompatibilityCheck: If running NetCoreCheck.exe fails with error code ERROR_EXE_MACHINE_TYPE_MISMATCH or ERROR_BAD_EXE_FORMAT then don't abort the installation, just set the property to 13.  Fixes issue #7737

commit e570ce5
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Sep 12 14:08:34 2023 -0700

    Update to latest signing infrastructure

    Fixes 7546

commit 409d3b6
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 17:31:08 2023 +1000

    add FIREWALL_EXCEPTION_ATTRIBUTES struct

commit e7656ce
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Sep 10 22:52:33 2023 -0400

    Remove unused symbol `Version`.

commit f18d7e6
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Sep 4 23:40:46 2023 -0700

    Correctly process build -outputType switch

    Also add a few additional output types to built-in backends.

    Fixes 7708

commit e29b4aa
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Mon Aug 21 11:34:51 2023 +1000

    remove windows xp specific code from firewall extension

commit b3deb46
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 08:31:28 2023 +1000

    add firewall extension decompiler

commit 537e79d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 20 19:49:21 2023 +1000

    use WcaGetRecordFormattedString to get firewall rule description

commit febb9c9
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 13 11:34:57 2023 +1000

    add integration tests for the firewall extenstion

commit 6f520b9
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Aug 15 18:05:47 2023 -0400

    Properly fragment NetFx custom actions.

    FIxes wixtoolset/issues#7677.

commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
nirbar added a commit to nirbar/wix4 that referenced this issue Feb 22, 2024
@nirbar
Squashed commit of the following:
ac17675 
commit 4f1209d
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Feb 17 18:48:59 2024 -0500

    Support loc strings for Directory/@shortname.

    Fixes wixtoolset/issues#7935.

commit a38b07a
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Feb 17 17:56:57 2024 -0500

    Allow MsiProperty/@value to be an empty string.

    Fixes wixtoolset/issues#7798.

commit e98ff25
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Feb 16 19:53:19 2024 -0500

    Test/sample for default major upgrade message.

commit 3fa1761
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Feb 16 18:34:12 2024 -0500

    Switch to `virtual` access modifiers...

    ...from `Overridable="yes"`.

    Fixes wixtoolset/issues#7981 for WiX v5.

commit eb2f85d
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Feb 3 22:52:23 2024 -0500

    Improve error when virtual action symbols collide.

commit bf1e74b
Author: Andrzej Wojtas <38528584+avjts@users.noreply.github.com>
Date:   Sat Jan 20 12:14:02 2024 +0100

    Fix crash when CloseApplications_X64 closes Electron app

commit dfea447
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Mon Jun 5 13:27:56 2023 +0300

    Fixes wixtoolset/issues#5220: Automatically add logging flag for any burn ExePackage, BundlePackage, and related bundles

commit cde596e
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jan 19 16:53:26 2024 -0500

    Clean up TouchFile.

commit 8b55203
Author: Rob Mensching <rob@firegiant.com>
Date:   Thu Jan 11 00:17:24 2024 -0800

    Correctly prefix the functions exposed from burnpipe.h

commit 8cfd711
Author: Rob Mensching <rob@firegiant.com>
Date:   Thu Jan 11 00:00:27 2024 -0800

    Update Burn to use pipeutil for low-level pipe operations

commit 4e7b7c0
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jan 10 23:53:18 2024 -0800

    Add pipeutil to dutil

    Plus a couple small clean-ups in a couple of dutil files.

commit 57b7689
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jan 10 23:48:40 2024 -0800

    Rename inter-Burn communication related pipe file

    When BootstrapperApplications move out of proc there will be another set of
    pipes in Burn that behave differently from the inter-Burn communication pipes
    that exist now. So renaming the existing pipe related files now to better
    reflect that it is related to Burn talking to Burn when elevated or embedded.

commit f676cee
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Sep 10 22:34:56 2023 -0400

    Support naked files.

    Implements wixtoolset/issues#7696.

    `File` elements can appear where `Component` elements do in WiX v4. The
    compiler generates an appropriate per-file component. Naked files under
    `Directory`, `DirectoryRef`, `Fragment`, `StandardDirectory`, or
    `Package` elements are included in a package via the [default-feature
    feature](wixtoolset/issues#7581). Naked files
    appearing under `ComponentGroup`, `Feature`, `FeatureRef`, and
    `FeatureGroup` generate the component and the reference to the parent
    element.

    Components and naked Files default to being installed to INSTALLFOLDER
    (including a default INSTALLFOLDER if one isn't otherwise authored).

commit 44a13ff
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Jan 1 22:07:46 2024 -0500

    Remove warning for `Wix` bundle variable prefix.

    It's a bit overzealous.

    Fixes wixtoolset/issues#7579.

commit 59ca477
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Dec 31 17:23:29 2023 -0500

    Use `/DEPENDENTLOADFLAG` to tell the loader...

    ...to load DLLs from System32 only.

    (Belt and suspenders to current approaches.) See
    https://devblogs.microsoft.com/oldnewthing/20230328-00/?p=107978.

    Fixes wixtoolset/issues#7319.

commit 32e3cc2
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Dec 31 17:12:28 2023 -0500

    Remove bundle container signing support.

    It was never implemented and ass-u-mes containers are cabs,
    which hopefully won't be the case forever.

    Fixes wixtoolset/issues#7490.

commit d56481c
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Dec 31 17:08:45 2023 -0500

    Rename IWindowsInstallerDecompileContext...

    ...TreatProductAsModule to KeepModularizationIds to better describe what
    it does.

    Fixes wixtoolset/issues#7607.

commit c890f0e
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Dec 30 22:53:21 2023 -0500

    Add a warning that VBScript is deprecated.

commit 1eea9c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Dec 23 21:37:02 2023 -0500

    Add default major upgrade.

    Add Package/@UpgradeStrategy to allow `none` to suppress major upgrade.

    Implements wixtoolset/issues#7605.

    Requires wixtoolset#435.

commit f4a0522
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 19:03:34 2023 -0400

    Provide a default INSTALLFOLDER.

    If INSTALLFOLDER is referenced and not defined, define one with
    reasonable default values.

    Implements WIP wixtoolset/issues#7588.

commit 1c249dd
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Dec 17 21:06:30 2023 -0500

    Implement default-feature feature.

    Use the WiX stdlib.

    See WIP at wixtoolset/issues#7581.

commit 6f4fda5
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Mon Nov 20 18:00:03 2023 +0200

    ArpEntry reads QuietUninstallString or UninstallString, and uses UninstallArguments for the uninstall command line

commit f02ef4a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Dec 18 19:44:47 2023 -0800

    Make the minimum supported .NET Framework v4.6.2

commit 7b63b09
Author: Christopher Painter <chrpai@iswix.com>
Date:   Tue Dec 5 23:19:19 2023 -0600

    Update Build Requirements

    Issue 7388

    Update README.md

    Add .NET 6.0 to list of components

commit 87a1ab5
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Dec 16 22:07:05 2023 -0500

    Enhance error message.

commit 0bf10d9
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Dec 16 09:03:44 2023 -0800

    Improve error reporting of duplicate symbols

    Virtual symbols provide more interesting ways to have (and avoid) conflicts.
    Adding additional messages and cleaning up the existing messages should help
    users know what options they have to address conflicts.

    This also puts all the conflict resolution in ReportConflictingSymbolsCommand
    instead of spreading it across reference resolution as well.

commit eff9d42
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Dec 6 19:48:54 2023 -0800

    Introducing the WiX Standard Library

    Completes 7914

commit 3799263
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Dec 5 16:11:05 2023 -0800

    Initial support for virtual symbols.

    Completes 7913

commit 7be5d94
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Dec 6 15:30:16 2023 -0800

    Link localizations from WixExtensions the same as sections

commit 1bdcbeb
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Dec 6 11:53:44 2023 -0800

    Pretty up build output

commit 6cd11a8
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 27 23:21:41 2023 -0800

    Fix build script to correctly reference wix5

commit e29ef30
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Sep 29 22:23:02 2023 -0700

    Update to xunit 2.5.1

commit 34132d8
Author: cpuwzd <30509574+cpuwzd@users.noreply.github.com>
Date:   Tue Dec 12 09:49:36 2023 -0500

    Resolve issues with inner text

    Fixes wixtoolset/issues#7739

commit 5f23086
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 26 22:40:25 2023 -0500

    Build tweaks to support VS 17.8...

    ...because SemVer is just a suggestion.

    - Also fix missing NuGet cleanup.
    - And update NuGet^2 packages because v6.3.1 has vulnerabilities.

commit e0a9ec5
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 21:11:51 2023 -0500

    Remove the deprecated DifxApp WiX extension.

    Per
    https://wixtoolset.org/docs/releasenotes/#deprecations-and-deletions.

commit e5ed750
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Nov 19 20:55:45 2023 -0500

    Clean up.

commit dfb7512
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Thu Sep 21 16:03:28 2023 +1000

    add firewall extension decompiler, make msi modifications work, add all attributes

commit 80e6047
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 18:51:38 2023 +1000

    change firewall extension table name to Wix5FirewallException

commit 6e97449
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 13 12:56:15 2023 -0800

    Return intermediate even if compiler encounters error

    Fixes 7854

commit a532341
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 21:46:30 2023 -0800

    Include duplicated inline directory symbols referenced in subsequent sections

    Due to the handling of redundant symbols, which are only used by inline directory
    syntax, the symbols were only defined in the first section encountered by the linker.
    Fix that so at most one duplicated inline directory symbol is included when
    referenced.

    Fixes 7840

commit 4b9bbae
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:45:46 2023 -0800

    Fix duplication of AdditionalOptions being added to command-line

    Fixes 7837

commit a886df0
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 22:36:57 2023 -0800

    Correctly handle top-level AppId element

    Fixes 7738

commit 96e9c0f
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Nov 6 23:08:10 2023 -0800

    Avoid use of Encoding.WindowsCodePage

    Fixes 7612

commit b842027
Author: Bob Arnson <bob@firegiant.com>
Date:   Mon Oct 23 00:17:18 2023 -0400

    Introduce a new phase in the build pipeline.

    A useful point in the build pipeline is after all the files in the
    project have been compiled but before they've been linked.
    The WiX core and extensions can operate on symbols across
    the project but without operating at the source-code level.

    This phase is currently named "optimize," after a moderately-similar
    phase in other compiler architectures. The name is, for now, a stake in
    the ground and a better alternate is welcome.

commit bb691bd
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:34 2023 -0400

    Random typo fix.

commit f5e164d
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Oct 13 20:22:21 2023 -0400

    Add cert and x64 tests.

commit 0014af6
Author: apacker1 <apacker1@users.noreply.github.com>
Date:   Fri Sep 22 14:41:57 2023 -0700

    DotNetCompatibilityCheck: If running NetCoreCheck.exe fails with error code ERROR_EXE_MACHINE_TYPE_MISMATCH or ERROR_BAD_EXE_FORMAT then don't abort the installation, just set the property to 13.  Fixes issue #7737

commit e570ce5
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue Sep 12 14:08:34 2023 -0700

    Update to latest signing infrastructure

    Fixes 7546

commit 409d3b6
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 17:31:08 2023 +1000

    add FIREWALL_EXCEPTION_ATTRIBUTES struct

commit e7656ce
Author: Bob Arnson <bob@firegiant.com>
Date:   Sun Sep 10 22:52:33 2023 -0400

    Remove unused symbol `Version`.

commit f18d7e6
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Sep 4 23:40:46 2023 -0700

    Correctly process build -outputType switch

    Also add a few additional output types to built-in backends.

    Fixes 7708

commit e29b4aa
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Mon Aug 21 11:34:51 2023 +1000

    remove windows xp specific code from firewall extension

commit b3deb46
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Aug 26 08:31:28 2023 +1000

    add firewall extension decompiler

commit 537e79d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 20 19:49:21 2023 +1000

    use WcaGetRecordFormattedString to get firewall rule description

commit febb9c9
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sun Aug 13 11:34:57 2023 +1000

    add integration tests for the firewall extenstion

commit 6f520b9
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Aug 15 18:05:47 2023 -0400

    Properly fragment NetFx custom actions.

    FIxes wixtoolset/issues#7677.

commit 59f37d2
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 15:43:10 2023 -0700

    Fix the use of ModuleSubstitution table

    Addresses two issues in the creation of configurable merge modules. First, the
    ModuleConfiguration table Id should not be modularized. Second, the
    ModuleSubstitution table was never created. Fixing both of those allows
    configurable merge modules to work again.

    Fixes 7559

commit 2b429e9
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:31:20 2023 -0700

    Remove Esproj test

    The npm packages in esproj regularly encounter security issues that are not
    relevant to WiX. The test provides less value than the churn required to keep
    all the test project up to date, so deleting it.

commit 9607c3a
Author: Rob Mensching <rob@firegiant.com>
Date:   Mon Aug 7 12:07:39 2023 -0700

    Ensure the Font actions are scheduled for TrueType fonts

    TrueType fonts are denoted by the empty string in the FontTitle field of the
    FileSymbol. That means a non-null FontTitle field value means a font is being
    installed.

    Fixes 7593

commit 6d5c4be
Author: Bob Arnson <bob@firegiant.com>
Date:   Sat Jul 29 20:57:14 2023 -0400

    Remove legacy permissions support.

    In the long ago, a share could have one user/permissions pair. That's
    really limited, of course, so support for _n_ user/permissions pairs
    was added. In the move to WiX v4, support for that single, legacy user
    was removed from the extension side but not the custom action side.
    Remove that support.

    Fixes wixtoolset/issues#7632.

commit d8832db
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Aug 2 19:39:25 2023 +1000

    fix stack corruption around cbdata when adding a machine certificate

commit 5e9901d
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Sat Jul 22 09:01:55 2023 +1000

    Multiple extension support in unit tests

commit 1c50eb8
Author: Bob Arnson <bob@firegiant.com>
Date:   Fri Jul 21 19:56:59 2023 -0400

    Fix mentions of dark.exe.

commit e0641f1
Author: Marco Stadler <marco.stadler@bruker.com>
Date:   Mon Apr 24 11:49:53 2023 +0200

    Allow custom package comments

    Fixes #7369

commit 42118ef
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:20:19 2023 -0700

    Fix out of date references to Product in warnings

    Fixes 7631

commit 7a603e4
Author: Rob Mensching <rob@firegiant.com>
Date:   Wed Jul 19 10:19:35 2023 -0700

    Remove invalid references to ToolsVersion in ext wixlib projects

commit d20b6d4
Author: chris_bednarski <Chris.Bednarski@minfos.com.au>
Date:   Wed Jul 19 10:11:18 2023 +1000

    feat(build): update xunit to version 2.5.0, fix occasional test timeout

commit cef14c6
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 15 15:40:37 2023 -0400

    Ensure extensions get the same decompiler helper.

    Fixes wixtoolset/issues#7548.

    THIS IS A BREAKING INTERFACE/EXTENSIBILITY CHANGE.

commit 164c29a
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jul 11 21:19:08 2023 -0400

    Partial fix for the weirdly broken...

    IWindowsInstallerDecompileContext.TreatProductAsModule.

    wixtoolset/issues#7607

commit 713f286
Author: Rob Mensching <rob@firegiant.com>
Date:   Sat Jul 8 09:10:50 2023 -0700

    Fix typo where Level was used instead of Value in Level element error message

    Fixes 7603

commit e53c658
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu Jun 29 21:16:35 2023 -0400

    Extract object fields with modularization GUIDs.

commit ddae99c
Author: Bob Arnson <bob@firegiant.com>
Date:   Tue Jun 20 20:09:19 2023 -0400

    Handle MergeModule.CABinet for extraction.

    Fixes wixtoolset/issues#7568,

commit 9a550ac
Author: Michael Stoll <michael.stoll@stolltec.com>
Date:   Wed May 3 18:04:48 2023 +0200

    Add more _NODOMAIN properties to WixQueryOsWellKnownSID

commit 35d30e0
Author: Bob Arnson <bob@firegiant.com>
Date:   Thu May 18 20:47:27 2023 -0400

    Improve logging to remove `(null)`.

    Add detached container runtime test.

    Inspired by wixtoolset/issues#7490.

commit f474066
Author: Jesper Hansen <jesper@staunhansen.dk>
Date:   Mon Jun 12 14:39:32 2023 +0200

    Update WindowsInstallerStandard.cs ordered sequence

    Ordered standard actions by sequence and group for more human readability

commit 2daf189
Author: Nir Bar <nir.bar@panel-sw.co.il>
Date:   Thu Apr 20 08:44:54 2023 +0300

    Allow customized AdditionalOptions for all HarvestX MSBuild ItemGroups

commit 783b829
Author: Rob Mensching <rob@firegiant.com>
Date:   Fri Jun 2 11:45:10 2023 -0700

    ProjectReferences to wixlibs should participate in DefineConstants creation

    Also fix documentation in ResolveWixLibraryReferences target.

    Fixes 7512

commit ed0a765
Author: Bob Arnson <bob@firegiant.com>
Date:   Wed May 31 16:04:27 2023 -0400

    Downgrade bad ProductVersion error to warning.

    Fixes wixtoolset/issues#7522.

commit bc9343a
Author: Rob Mensching <rob@firegiant.com>
Date:   Tue May 30 08:28:14 2023 -0700

    Obsolete removed PackageState.Cached value

    A package's cached status is no longer set via the PackageState. The value was
    removed in native code but the managed code was missed throwing off the enum
    mapping.

    Fixes 7399
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barnson barnson

Labels
decompiler
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging a pull request may close this issue.

Handle MergeModule.CABinet for extraction. wixtoolset/wix
2 participants
@robmen @barnson