Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug/Solution] | Setting a Github Rate limit for statistics on the site #440

Closed
2 tasks done
ramazansancar opened this issue May 28, 2024 · 3 comments
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@ramazansancar
Copy link

ramazansancar commented May 28, 2024

Are you using the latest release?

  • Yes, I am using the latest release.

Have you checked a bug report doesn't already exist?

  • Yes, I have checked the existing bug reports.

What happened?

It may be better to create a script for the statistics section of your website and run it periodically with cron via github action, keeping the data in a json file in the repo or in the docs to feed the website.

image

Virtualisation

Other

What operating system are you seeing the problem on?

Other

What browsers are you seeing the problem on?

Chrome

Project Location

Somewhere else (please specify in the description!)

Bug Description

It may be better to create a script for the statistics section of your website and run it periodically with cron via github action, keeping the data in a json file in the repo or in the docs to feed the website.

See here: https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting

Steps to Reproduce

No response

Relevant Log Output

No response

@ramazansancar ramazansancar added the bug Something isn't working label May 28, 2024
@ramazansancar ramazansancar changed the title [Bug/Solution] | [Bug/Solution] | Setting a Github Rate limit for statistics on the site May 28, 2024
@albinmedoc
Copy link

I agree, this should really be fixed.

It looks like the script is fetching 100 commits/request and summing it up to give the total number of commits.
When I'm writing this, it makes 24 request just to get the number of commits. Number of request will just increase when wizarr grows.

The same if for contributors. 100 contributors/request.

Currently, 29 request are made to github when I visit wizarr.dev

@JamsRepos
Copy link
Member

I don't actually have access to where this site is hosted, it'll need to be moved eventually. For now, i've removed the statistics off here, I would make the repository open but I believe TailwindUI was used and paid for in this repo so it's probably best I don't.

@ramazansancar
Copy link
Author

Thanks for your review @JamsRepos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants