Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExceptionExercisesTest #38

Closed
Ttcao opened this issue Apr 30, 2018 · 2 comments
Closed

ExceptionExercisesTest #38

Ttcao opened this issue Apr 30, 2018 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Ttcao
Copy link
Collaborator

Ttcao commented Apr 30, 2018

For the createPerson function the assertions need to be fixed for the tests:

  • "should return Person if supplied a valid name and age"
    The test should assert Person("Fred", 32)

  • "should throw an EmptyNameException if the name supplied is empty"
    The test should assert "provided name is empty"

  • "should throw an InvalidAgeValueException if the age supplied is not an Int"
    The test should assert InvalidAgeValueException is thrown instead of InvalidAgeRangeException

@sanjivsahayamrea
Copy link
Contributor

nice work @Ttcao. Looking forward to your PR. :)

@sanjivsahayamrea sanjivsahayamrea added the bug Something isn't working label Apr 30, 2018
@wjlow
Copy link
Owner

wjlow commented Apr 30, 2018

Closed in #39

@wjlow wjlow closed this as completed Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants