Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need Wallet in TypeExercises? #71

Closed
sanjivsahayamrea opened this issue May 3, 2018 · 1 comment
Closed

Do we need Wallet in TypeExercises? #71

sanjivsahayamrea opened this issue May 3, 2018 · 1 comment
Labels
possibly-remove remove to make content easier

Comments

@sanjivsahayamrea
Copy link
Contributor

sanjivsahayamrea commented May 3, 2018

We cover most of what Wallet does in TypeExercises with Person. Do we need to double up?

 //Type -> String
  def showWallet(wallet: Wallet): String = ???

is the same as:

def showPerson1(person: Person): String 
def showPerson2(person: Person): String 
 //immutable copy
  def purchase(cost: Double, wallet: Wallet): Wallet = ???

is the same as:

 def changeName(newName: String, person: Person): Person = ???
@sanjivsahayamrea sanjivsahayamrea added the possibly-remove remove to make content easier label May 3, 2018
@wjlow
Copy link
Owner

wjlow commented May 3, 2018

I think this is a good one to keep.

Redundancy may be useful at this point since this is right at the very beginning.

@wjlow wjlow closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
possibly-remove remove to make content easier
Projects
None yet
Development

No branches or pull requests

2 participants