Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtlasAttributeDef should handle CARDINALITY as an enum and not raw value #185

Closed
wjohnson opened this issue Jan 24, 2022 · 0 comments
Closed

AtlasAttributeDef should handle CARDINALITY as an enum and not raw value #185

wjohnson opened this issue Jan 24, 2022 · 0 comments

Comments

@wjohnson
Copy link
Owner

Currently, AtlasAttributeDef appears to take in Cardinality as either the raw object passed in or defaults to Cardinality.SINGLE.value.

Instead, the raw value should be copied in, tested if it's a Cardinality type then coerce it, else accept it.
wjohnson added a commit that referenced this issue Feb 27, 2022
@wjohnson
Closes #185 by properly handling the enum Cardinality type when
f6dba0e 
adding it to the AtlasAttributeDef
wjohnson added a commit that referenced this issue Feb 27, 2022
@wjohnson
Closes #185 by properly handling the enum Cardinality type when
1895a84 
adding it to the AtlasAttributeDef
@wjohnson wjohnson mentioned this issue Feb 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wjohnson