Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target browsers in Babel config for CJS/ESM builds #9

Closed
wKovacs64 opened this issue Jun 26, 2017 · 0 comments
Closed

Target browsers in Babel config for CJS/ESM builds #9

wKovacs64 opened this issue Jun 26, 2017 · 0 comments

Comments

@wKovacs64
Copy link
Owner

"browsers": [
  "> 1%",
  "last 2 versions"
],

This will be required if #8 is implemented, as the current CommonJS/ES module builds contain features that don't work across all the browsers this project aims to support (template literals, in particular).

It should really be added regardless, as people may even be wanting to circumvent the browser field already and explicitly import a non-UMD build on their own. Currently, when attempting to bundle a non-UMD build with webpack, the included UglifyJsPlugin will error during minification as it can't handle ES2015 features yet. (There are workarounds for this, such as bringing in the next version of UglifyJs or using a different minifier all together.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant