Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdl1+sdl2 missing install option #77

Closed
GitMensch opened this issue Oct 15, 2019 · 3 comments
Closed

sdl1+sdl2 missing install option #77

GitMensch opened this issue Oct 15, 2019 · 3 comments

Comments

@GitMensch
Copy link
Contributor

sdl2 has ´install listed as ´.PHONY target, but doesn't define the target itself. sdl1 has no mention of the install target at all.

Suggestion: create the target for both using something like the one used for x11.

@wmcbrine
Copy link
Owner

wmcbrine commented Oct 17, 2019

Yeah, looks like a leftover from before d4557e6.

(No, I'm not adding install targets.)

@GitMensch
Copy link
Contributor Author

GitMensch commented Oct 17, 2019

Broken install target for SDL2 removed with 8a28cf8.
@wmcbrine just to add the missing bit of information here: Why do you dislike the install target for SDL1 and SDL2 (where it was existing before) but not for X11?

@wmcbrine
Copy link
Owner

wmcbrine commented Dec 8, 2019

It wasn't really existing in SDL2, from my perspective -- it was added and removed before it was ever submitted to me.

And, actually, I don't like it in X11. 200K extra just for the configure script and its supporting files? I'd love to dump that. But realistically, I can't. It's established, and people depend on it.

As well, the SDL makefiles aren't Unix-specific, as the X11 stuff is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants