Increase code coverage to 100%

wmde · Mar 15, 2016 · d658952 · d658952
1 parent d4745ef
commit d658952
Show file tree

Hide file tree

Showing 3 changed files with 47 additions and 4 deletions.
diff --git a/tests/phpunit/Comparer/ComparableComparerTest.php b/tests/phpunit/Comparer/ComparableComparerTest.php
@@ -54,6 +54,14 @@ public function testDifferentValuesAreNotEqual( $firstValue, $secondValue ) {
 
 	public function unequalProvider() {
 		return array(
+			array(
+				null,
+				null
+			),
+			array(
+				new StubComparable( 1 ),
+				null
+			),
 			array(
 				new StubComparable( 1 ),
 				new StubComparable( 2 ),

diff --git a/tests/phpunit/DiffOp/Diff/DiffTest.php b/tests/phpunit/DiffOp/Diff/DiffTest.php
@@ -679,10 +679,15 @@ public function testEquals( Diff $diff, Diff $target ) {
 	}
 
 	public function equalsProvider() {
+		$empty = new Diff();
+
 		return array(
+			// Identity
+			array( $empty, $empty ),
+
 			// Empty diffs
-			array( new Diff(), new Diff() ),
-			array( new Diff(), new Diff( array(), null ) ),
+			array( $empty, new Diff() ),
+			array( $empty, new Diff( array(), null ) ),
 
 			// Simple diffs
 			array( new Diff( array( new DiffOpAdd( 1 ) ) ), new Diff( array( new DiffOpAdd( 1 ) ) ) ),
@@ -697,13 +702,16 @@ public function equalsProvider() {
 	/**
 	 * @dataProvider notEqualsProvider
 	 */
-	public function testNotEquals( Diff $diff, Diff $target ) {
+	public function testNotEquals( Diff $diff, $target ) {
 		$this->assertFalse( $diff->equals( $target ) );
-		$this->assertFalse( $target->equals( $diff ) );
 	}
 
 	public function notEqualsProvider() {
 		return array(
+			// Not an instance or subclass of Diff
+			array( new Diff(), null ),
+			array( new Diff(), new DiffOpAdd( 1 ) ),
+
 			// Empty diffs
 			array( new Diff(), new Diff( array(), false ) ),
 			array( new Diff(), new Diff( array(), true ) ),

diff --git a/tests/phpunit/Differ/ListDifferTest.php b/tests/phpunit/Differ/ListDifferTest.php
@@ -3,6 +3,7 @@
 namespace Diff\Tests\Differ;
 
 use Diff\ArrayComparer\NativeArrayComparer;
+use Diff\ArrayComparer\StrictArrayComparer;
 use Diff\Differ\Differ;
 use Diff\Differ\ListDiffer;
 use Diff\DiffOp\DiffOpAdd;
@@ -20,6 +21,32 @@
  */
 class ListDifferTest extends DiffTestCase {
 
+	public function arrayComparerProvider() {
+		$add = array( new DiffOpAdd( 1 ) );
+
+		return array(
+			'null' => array( null, $add ),
+			'native const' => array( ListDiffer::MODE_NATIVE, array() ),
+			'strict const' => array( ListDiffer::MODE_STRICT, $add ),
+			'native object' => array( new NativeArrayComparer(), array() ),
+			'strict object' => array( new StrictArrayComparer(), $add ),
+		);
+	}
+
+	/**
+	 * @dataProvider arrayComparerProvider
+	 */
+	public function testConstructor( $arrayComparer, array $expected ) {
+		$differ = new ListDiffer( $arrayComparer );
+		$diff = $differ->doDiff( array( 1 ), array( 1, 1 ) );
+		$this->assertEquals( $expected, $diff );
+	}
+
+	public function testInvalidConstructorArgument() {
+		$this->setExpectedException( 'InvalidArgumentException' );
+		new ListDiffer( 2 );
+	}
+
 	/**
 	 * Returns those that both work for native and strict mode.
 	 */