Upgrade to PHP7 #74
Merged
Upgrade to PHP7 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
JeroenDeDauw
commented
Nov 18, 2016
•
JeroenDeDauw
commented
|
A self-merge? On master? I would have preferred a "php7" branch or something, as long as we need this component to be compatible with PHP 5. How are we going to update this now? Which version number will we use when we need to introduce a breaking change, but still need PHP 5 compatibility? Can we please solve this problem somehow? Can we please talk about this before doing actual self-merges? Can we please document the proposed way of us working together somehow? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.