Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Add a hidden label for screen readers #74

Merged
merged 2 commits into from
Nov 27, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 43 additions & 21 deletions src/components/ValueTypeDropDown.vue
Original file line number Diff line number Diff line change
@@ -1,17 +1,25 @@
<template>
<select
class="querybuilder__dropdown"
v-model="selected"
>
<option
class="querybuilder__dropdown-option"
v-for="(optionItem, index) in optionItems"
:value="optionItem"
:key="index"
<div class="querybuilder__dropdown">
<label id="valueTypeSelect"
class="querybuilder__dropdown-label">
Value Type
</label>
<select
class="querybuilder__dropdown-select"
v-model="selected"
aria-labelledby="valueTypeSelect"
>
{{ optionItem }}
</option>
</select>
<option
class="querybuilder__dropdown-option"
v-for="(optionItem, index) in optionItems"
:value="optionItem"
:key="index"
>
{{ optionItem }}
</option>
</select>
</div>

</template>

<script lang="ts">
Expand Down Expand Up @@ -45,14 +53,28 @@ export default Vue.extend( {
<style scoped lang="scss">
// will be removed once dropdown component is implemented in the DS
.querybuilder__dropdown {
width: 256px;
height: 32px;
margin-inline-start: $dimension-layout-xsmall;
margin-block-start: 23px;
border-color: #a2a9b1;
border-style: solid;
border-width: 1px;
border-radius: 2px;
appearance: auto;
&-select {
width: 256px;
height: 32px;
margin-inline-start: $dimension-layout-xsmall;
margin-block-start: 23px;
border-color: #a2a9b1;
border-style: solid;
border-width: 1px;
border-radius: 2px;
appearance: auto;
}

&-label {
position: absolute;
width: 1px;
height: 1px;
overflow: hidden;
clip: rect(0, 0, 0, 0);
white-space: nowrap;
-webkit-clip-path: inset(50%);
clip-path: inset(50%);
border: 0;
}
}
</style>