Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUILD ERROR] Complex coastline ADM0 cases #1628

Closed
DanRunfola opened this issue Jul 27, 2021 · 2 comments
Closed

[BUILD ERROR] Complex coastline ADM0 cases #1628

DanRunfola opened this issue Jul 27, 2021 · 2 comments
Assignees
@DanRunfola
Milestone
4.0.0

Comments

@DanRunfola
Copy link
Member

DanRunfola commented Jul 27, 2021 •
edited
Loading

A few countries are breaking on build, mostly those with intricate coastlines:
ADM0 - Japan, Chile, New Zealand, Norway
@DanRunfola DanRunfola added this to the 4.0.0 milestone Jul 27, 2021
@DanRunfola DanRunfola self-assigned this Jul 27, 2021
@DanRunfola DanRunfola changed the title [BUILD ERROR] [BUILD ERROR] Complex coastline ADM0 cases Jul 27, 2021
@DanRunfola
Copy link
Member Author

Ok - scratch this - looks like these are failing in the metadata production script, probably on the vertex calculations. Digging further.

@DanRunfola
Copy link
Member Author

This has been fixed, at least temporarily, by counting vertices from a JSON object.

Definitely need to do some more digging on this eventually, but closing for now with this bandaid.

wmgeolab/geoBoundaryBot@a15800b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanRunfola DanRunfola

Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@DanRunfola