Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BRA_ADM1 #2670 #2793

Merged
merged 7 commits into from
May 2, 2023
Merged

BRA_ADM1 #2670 #2793

merged 7 commits into from
May 2, 2023

Conversation

jamesnelmore
Copy link
Contributor

Why do we need this boundary?

Anything Unusual?

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

OVERALL STATUS: 3 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: You submitted at least one file that is missing a meta.txt, which is required. Please make sure your meta.txt is in the root of your submitted zip file - I have not yet been programmed to look in folders for your meta.txt.
Full logs for fileChecks

geometryDataChecks: A geometry or data check failed for the file you submitted - take a look at the logs to see what happened.
Full logs for geometryDataChecks

metaChecks: It looks like your metadata has one or more errors - take a look at the logs to see what you need to fix.
Full logs for metaChecks

----- Preview -----
Preview

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

OVERALL STATUS: 3 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: You submitted at least one file that is missing a meta.txt, which is required. Please make sure your meta.txt is in the root of your submitted zip file - I have not yet been programmed to look in folders for your meta.txt.
Full logs for fileChecks

geometryDataChecks: A geometry or data check failed for the file you submitted - take a look at the logs to see what happened.
Full logs for geometryDataChecks

metaChecks: It looks like your metadata has one or more errors - take a look at the logs to see what you need to fix.
Full logs for metaChecks

----- Preview -----
Preview

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

OVERALL STATUS: 3 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: You submitted at least one file that is missing a meta.txt, which is required. Please make sure your meta.txt is in the root of your submitted zip file - I have not yet been programmed to look in folders for your meta.txt.
Full logs for fileChecks

geometryDataChecks: A geometry or data check failed for the file you submitted - take a look at the logs to see what happened.
Full logs for geometryDataChecks

metaChecks: It looks like your metadata has one or more errors - take a look at the logs to see what you need to fix.
Full logs for metaChecks

----- Preview -----
Preview

Copy link
Collaborator

@lydiatroup lydiatroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes needed for this file:

  1. the name of the shapefile itself should be titled BRA_ADM1
  2. source 2 in the meta data should be "Wikimedia Commons" because that is where the digitized image came from
  3. license should be "Creative Commons Attribution 2.5 Generic"

also a note for the future, the automated digitizing is definitely cool, but you will need to smooth out the edges for file submissions from it (ie making them not as jagged / pixelated on the feature's edges)

please upload this change as a new PR and we can see if that'll fix the file error too

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for metaChecks

OVERALL STATUS: 1 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: All checks PASSED. Nothing that needs to be done here right now.
Full logs for fileChecks

geometryDataChecks: A geometry or data check failed for the file you submitted - take a look at the logs to see what happened.
Full logs for geometryDataChecks

metaChecks: All checks PASSED. Nothing that needs to be done here right now.
Full logs for metaChecks

----- Preview -----
Preview

1 similar comment
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for metaChecks

OVERALL STATUS: 1 checks are failing. I have some recommendations for you on how you might fix these.

fileChecks: All checks PASSED. Nothing that needs to be done here right now.
Full logs for fileChecks

geometryDataChecks: A geometry or data check failed for the file you submitted - take a look at the logs to see what happened.
Full logs for geometryDataChecks

metaChecks: All checks PASSED. Nothing that needs to be done here right now.
Full logs for metaChecks

----- Preview -----
Preview

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for geometryDataChecks

Full logs for metaChecks

All checks have passed! I'll flag your boundary submission for a manual review by one of my humans.
Preview

Copy link
Collaborator

@lydiatroup lydiatroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes are needed:

  • Source 1: should be geoBoundaries and source2: should be Wikimedia Commons
  • Your attribute table has a few extra columns. Please remove the InPoly_FID, Shape_Le_1, and Shape_Area fields
  • In the attribute table your ISO_Code and Level columns are flipped. ISO_Code should be the BR- values, while Level should be "ADM1"

Also great work on smoothing out the lines! this looks really good.

@github-actions
Copy link

Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files.

I will automatically re-run my checks when you edit your Pull Request, and provide the new results in a comment just like this.
Once all of your files meet my programmed standards, I will flag your file for a manual human review.
=========== Submission Findings ===========

Full logs for fileChecks

Full logs for geometryDataChecks

Full logs for metaChecks

All checks have passed! I'll flag your boundary submission for a manual review by one of my humans.
Preview

@jamesnelmore
Copy link
Contributor Author

I've made those changes. Thank you!

Copy link
Collaborator

@lydiatroup lydiatroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great!! thanks! closes #2670

@DanRunfola DanRunfola merged commit dde1e95 into main May 2, 2023
4 checks passed
@DanRunfola DanRunfola deleted the BRA_ADM1 branch May 2, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants