-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BRA_ADM1 #2670 #2793
BRA_ADM1 #2670 #2793
Conversation
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes needed for this file:
- the name of the shapefile itself should be titled BRA_ADM1
- source 2 in the meta data should be "Wikimedia Commons" because that is where the digitized image came from
- license should be "Creative Commons Attribution 2.5 Generic"
also a note for the future, the automated digitizing is definitely cool, but you will need to smooth out the edges for file submissions from it (ie making them not as jagged / pixelated on the feature's edges)
please upload this change as a new PR and we can see if that'll fix the file error too
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
1 similar comment
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes are needed:
- Source 1: should be geoBoundaries and source2: should be Wikimedia Commons
- Your attribute table has a few extra columns. Please remove the InPoly_FID, Shape_Le_1, and Shape_Area fields
- In the attribute table your ISO_Code and Level columns are flipped. ISO_Code should be the BR- values, while Level should be "ADM1"
Also great work on smoothing out the lines! this looks really good.
Hello! I am the geoBoundary Bot, and I just did an initial check on your submitted files. |
I've made those changes. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!! thanks! closes #2670
Why do we need this boundary?
Anything Unusual?