Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling session.install() with keyword argument silent causes TypeError #156

Closed
erinwild opened this issue Nov 4, 2018 · 1 comment
Closed

Calling session.install() with keyword argument silent causes TypeError #156

erinwild opened this issue Nov 4, 2018 · 1 comment

Comments

@erinwild
Copy link

erinwild commented Nov 4, 2018

For example, running session.install("requests", "urllib3", silent=False) results in the following error:

TypeError: run() got multiple values for keyword argument 'silent'

This is because session.install() calls self.run("pip", "install", "--upgrade", *args, silent=True, external="error", **kwargs) which doesn't allow for silent or external to be set in kwargs.

I'll be opening a pull request shortly which checks if silent is found in kwargs before attempting to set a default.
@erinwild erinwild mentioned this issue Nov 4, 2018
Merged
@stsewd
Copy link
Collaborator

stsewd commented Nov 11, 2018

This was fixed in #157

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@theacodes @stsewd @erinwild