Strange lint CI failure?

[FollowTheProcess]

Describe the bug

Noticed a lint job failure after merging #543 (which had no such failure on the PR):

See here

I tried re-running but got the same outcome, then on my fork I tried adding python -m pip install --upgrade pip setuptools wheel to all CI jobs but got the same outcome

Edit: Also tried injecting setuptools directly into the nox session with session.install("setuptools", "pre-commit"), same result

Edit2: It seemed to always happen on isort so I tried removing it from the pre-commit config but it then just failed on black with the exact same error

How to reproduce

Look at the CI lint job, it seems to happen on re-runs

Expected behavior

Should run to success like in the PR

[cjolowicz]

I could only skim through them, but the failure may be related to these issues:

• ModuleNotFoundError: No module named 'setuptools._distutils' pypa/setuptools#2353
• virtualenv with --system-site-packages breaks pip's build isolation pypa/pip#6264 (comment)

Would updating setuptools in the runner's Python installation help?

python -m pip install -U setuptools

I'm assuming here that which python prints /opt/hostedtoolcache/Python/3.9.9/x64/bin/python, as that's the runner's Python installation. Maybe add that line to the workflow when testing.

[FollowTheProcess]

I'm assuming here that which python prints /opt/hostedtoolcache/Python/3.9.9/x64/bin/python, as that's the runner's Python installation. Maybe add that line to the workflow when testing.

Yep!

I tried python -m pip install -U setuptools too to no avail: here

Very strange

I can't replicate it locally either with makes me think it's a GHA runner related thing?

[cjolowicz]

I tried python -m pip install -U setuptools too to no avail: here

You need to invoke this outside of the virtualenv created by Nox.

Alternatively, use the full path:

/opt/hostedtoolcache/Python/3.9.9/x64/bin/python -m pip install -U setuptools

[cjolowicz]

Sorry I didn't see you were already doing this.

[FollowTheProcess]

There was a new release of virtualenv today which bumped the embedded version of setuptools, that's next on my list!

[FollowTheProcess]

It looks like virtualenv is the culprit! See my now passing lint run here

Pinning virtualenv to 20.10.0 inside the lint session has fixed it.

pre-commit depends on virtualenv>=20.0.8

So it must have pulled in today's 20.11.0, I guess they released it in between the PR and the CI run after the merge.

virtualenv 20.11.0 bumps the embedded setuptools from 58.3.0 to 59.4.0 so I guess there is a breaking change in there somewhere. Weird that I couldn't reproduce locally though, even with these versions