Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate market data #44

Closed
johnjohndoe opened this issue Apr 12, 2016 · 8 comments
Closed

Validate market data #44

johnjohndoe opened this issue Apr 12, 2016 · 8 comments
Assignees
@johnjohndoe
Labels
Enhancement State: Work in progress Validation

Comments

@johnjohndoe
Copy link
Member

I am currently working on a script which will validate the market data. I start with approving the opening hours format. The script will be automatically executed on Travis CI whenever a pull request is created.
@johnjohndoe johnjohndoe self-assigned this Apr 12, 2016
@torfsen
Copy link
Member

torfsen commented Apr 12, 2016

Good idea! Please integrate your script into our current test setup, so that running npm test executes it.

@johnjohndoe
Copy link
Member Author

@torfsen @k-nut I pushed a draft to this branch. Can you please review this and tell me how I can integrate it with Travis CI? I add metadata validation on another day.

@k-nut
Copy link
Member

k-nut commented Apr 13, 2016

Created a PR for this #48 . Essentially it is just one line in the .travis.yml

@johnjohndoe
Copy link
Member Author

Branch updated. Please review again.

This was referenced Apr 14, 2016
Closed
Closed
@johnjohndoe
Copy link
Member Author

Updated (renamed "warning" to "error" basically). Updated documentation.

@johnjohndoe johnjohndoe mentioned this issue Apr 17, 2016
Closed
@johnjohndoe
Copy link
Member Author

@k-nut @tursics @dirkschumacher Please review.

@k-nut
Copy link
Member

k-nut commented Apr 19, 2016 •
edited

@johnjohndoe can you make this into a PR so that we can comment on your changes inline?

@johnjohndoe
Copy link
Member Author

@k-nut Done in #63.

This was referenced Apr 22, 2016
Closed
Closed
Closed
Closed
@k-nut k-nut closed this as completed in fcba3aa Jul 4, 2016
joergreichert added a commit to joergreichert/wo-ist-testzentrum.github.io that referenced this issue Jan 1, 2022
@joergreichert
Merge pull request wo-ist-markt#44 from johnjohndoe/berlin-updates
d1911e4 
Update data for Berlin (21.12.2021).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnjohndoe johnjohndoe

Labels
Enhancement State: Work in progress Validation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@johnjohndoe @k-nut @torfsen