Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aur Package lto issue #226

Closed
LuisB79 opened this issue Sep 17, 2023 · 5 comments · Fixed by #227
Closed

Aur Package lto issue #226

LuisB79 opened this issue Sep 17, 2023 · 5 comments · Fixed by #227

Comments

@LuisB79
Copy link
Collaborator

LuisB79 commented Sep 17, 2023

You need to disable lto at PKGBUILD to compile properly the program, if not #191 will occur. Please add '!lto' into options array

@woelper woelper linked a pull request Sep 19, 2023 that will close this issue
@woelper
Copy link
Owner

woelper commented Sep 19, 2023

Cool, then I remove LTO and release. If that's still an issue we'll look at disabling LTO from the release build or make it optional. I think it may give a minimal speedup, so removing it might come as a cost.

1 similar comment
@woelper
Copy link
Owner

woelper commented Sep 19, 2023

Cool, then I remove LTO and release. If that's still an issue we'll look at disabling LTO from the release build or make it optional. I think it may give a minimal speedup, so removing it might come as a cost.

@LuisB79
Copy link
Collaborator Author

LuisB79 commented Sep 19, 2023

Cool, then I remove LTO and release. If that's still an issue we'll look at disabling LTO from the release build or make it optional. I think it may give a minimal speedup, so removing it might come as a cost.

Im going to check on it!

@woelper
Copy link
Owner

woelper commented Sep 19, 2023

As soon as you give me an OK on this one, chief!
#227

@LuisB79
Copy link
Collaborator Author

LuisB79 commented Sep 19, 2023

it worked!, now cargo.toml still has lto, so im betting the binary still has lto, even though the makepkg has !lto, but im not sure, i dont know who can confirm that,

@LuisB79 LuisB79 closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants