Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing theme template #6

Closed
JohnnyKing94 opened this issue Sep 3, 2016 · 4 comments
Closed

Missing theme template #6

JohnnyKing94 opened this issue Sep 3, 2016 · 4 comments
Labels
enhancement

Comments

@JohnnyKing94
Copy link
Contributor

When we give the consent to authorize the Rocket.Chat app for the account, i see this page rendered in a wrong way... like it's not loading any themes or templates... i don't know if it is done on purpose, but i'd like to have our proper theme rendered for this page

authorization-page
@wohali
Copy link
Owner

wohali commented Sep 5, 2016

It's intentional. Rendering within the theme is something we can consider for the future but is a non-trivial change given how the integration is written.

@JohnnyKing94
Copy link
Contributor Author

By the way, everything is localizable in that page, except for Yes and No, if i change the values, the new registrations won't be allowed, only logins... i thought it has to do with the code...

@wohali
Copy link
Owner

wohali commented Sep 9, 2016

Correct, that's a known limitation. I'll open a new issue on this as an enhancement, but don't expect a fix anytime soon.

@wohali wohali mentioned this issue Sep 9, 2016
Closed
@wohali
Copy link
Owner

wohali commented Jun 25, 2017

Fixed in 1.3.0.

@wohali wohali closed this as completed Jun 25, 2017
wohali added a commit that referenced this issue Jun 26, 2017
@wohali
v1.3.0: 2 bug fixes, 2 new features
8519c97 
* Fix execute permissions on interface pages (visit ACP > Community > OAuth2 Server > Applications to fix)
* Fix double-login required on initial visit (RFC3986 compatible argument passing)
* Enable site template on authorization page
* Allow localisation of "Yes" and "No" on authorization page

Closes #16
Closes #6
Closes #7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wohali @JohnnyKing94