Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hourly vaues should be reset for ever day #23

Closed
marku5 opened this issue Jun 25, 2024 · 7 comments
Closed

Hourly vaues should be reset for ever day #23

marku5 opened this issue Jun 25, 2024 · 7 comments

Comments

@marku5
Copy link

marku5 commented Jun 25, 2024

Bug or idea?

Main screen shows three sections:

  1. Hourly values
  2. Daily values as values
  3. Daily values as barchart

Values in 2. and 3. are reset every day.
The sum of kWh in 1. is summarized for all shown days => These values shall as well be set to zero in midnight.

@marku5 marku5 added the bug Something isn't working label Jun 25, 2024
@woheller69 woheller69 removed the bug Something isn't working label Jun 25, 2024
@martinrieder
Copy link

martinrieder commented Jun 30, 2024

I agree to the point that @marku5 brings up, but I generally do not see a real benefit from the hourly sum.

My personal opinion: Simply remove it!

Note that the numbers displayed as Wh tend to be quite long, which causes the entries to be further apart than in the weekly view.

Screenshot_20240630-092958~2.png

See how it displays only 3 hours on my screen, while the daily view shows 4.5 days. Removing the hourly sum would therefore condense the hourly display.

Additional thought, but different issue: Displaying the units below the numbers could further condense both views.

@woheller69
Copy link
Owner

the hourly sum helps finding the right pramaters by comparing with measured production values

@marku5
Copy link
Author

marku5 commented Jun 30, 2024

To clarify: I like the hourly sum, just not the "no value reset at midnight".

@martinrieder
Copy link

martinrieder commented Jun 30, 2024

@woheller69 wrote:

the hourly sum helps finding the right pramaters by comparing with measured production values

Then it would be useful to also show a daily sum? Should there possibly be a way to enter a starting value for this sum?

Anyhow, users would need to read their energy counter at different times and compare the difference. This is a backward-looking calculation, while the app provides a prediction for the coming hours/days. By giving the initial value, the sum would predict the reading of your energy counter.

@marku5 wrote:

To clarify: I like the hourly sum, just not the "no value reset at midnight".

I understand your point. The issue is perfectly valid. I just mentioned that I have a different view on this. Maybe I will raise another issue to show values in a more compact way then.

@woheller69
Copy link
Owner

Please try this apk

-Backup your settings
-Uninstall
-Remove .zip and install
-Restore settings

Values are reset at midnight if not in debug mode

app-release.apk.zip

@woheller69 woheller69 reopened this Jul 1, 2024
@marku5
Copy link
Author

marku5 commented Jul 1, 2024

Works! Thanks for the fix/new feature!

@martinrieder
Copy link

Also works for me. It clarifies the relation when the sums in the hourly and the daily view are matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants