Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-clock has dependency on "@types/react": "*" #132

Closed
rcbevans opened this issue Feb 6, 2023 · 4 comments
Closed

react-clock has dependency on "@types/react": "*" #132

rcbevans opened this issue Feb 6, 2023 · 4 comments

Comments

@rcbevans
Copy link

rcbevans commented Feb 6, 2023

Yarn is pulling in @types/react 18 into my react 17 project because of this transitive dependency which is causing type errors due to incompatible react definitions.

@wojtekmaj
Copy link
Owner

Not sure what can I do about that. You can certainly dedupe dependency yourself, but I understand this is suboptimal. Any other ideas how I can help out?

@rcbevans
Copy link
Author

Just need to remove it from deps and make it a devDep, same as in react-time-picker.

I was able to explicitly make react-clock 4.0 a dependency and that worked around it for now.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this issue will be closed in 14 days.

@github-actions github-actions bot added the stale label Jul 3, 2023
@github-actions
Copy link
Contributor

This issue was closed because it has been stalled for 14 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2023
@wojtekmaj wojtekmaj reopened this Jul 17, 2023
@wojtekmaj wojtekmaj added the bug label Jul 17, 2023
wojtekmaj added a commit that referenced this issue Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants