Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary declare module block in typings #419

Closed
wants to merge 4 commits into from

Conversation

JounQin
Copy link

@JounQin JounQin commented Jul 19, 2022

The typings are in its own package, so declare module is redundant.

@JounQin
Copy link
Author

JounQin commented Jul 25, 2022

ping @wojtekmaj

@wojtekmaj
Copy link
Owner

In this case, what about entry.nostyle.d.ts?

@JounQin
Copy link
Author

JounQin commented Jul 25, 2022

In this case, what about entry.nostyle.d.ts?

@wojtekmaj

It is not types in package.json, or the same dir as dist/entry.nostyle .js, so its declare module is required, and this PR will not break that.

Personally, I would prefer to have entry.nostyle.d.ts at dist/entry.nostyle.d.ts, then no declare module is required.

@wojtekmaj
Copy link
Owner

No longer relevant as React-Date-Picker is now natively in TypeScript.

@wojtekmaj wojtekmaj closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants