"Show less common lifecycles" shows more lifecycles - confusing wording

[danvc]

Hey brother, how are you doing?

Nice work on this diagram! I'm just creating this PR to fix a small issue. Have a good weekend!

The current implementation doesn't apply the "Show Less" logic according the current value.

[wojtekmaj]

Hey Dan! Thanks for your words and for PR.

The checkbox is actually working correctly, but wording should be better, because I see it confuses some people, including you.

"Show less common lifecycles" means "Show me also those lifecycles which are less common" and NOT "Show me less lifecycles".

Any ideas to make it more clear?

[danvc]

Hi Wojciech!

You're right. Changing the label will would help. How about: "Show all lifecycles"? Once the "basic" lifecycles are already being shown, once selected would show all cycles.

After reading your source code, looks like that it's very structured. I learned about Parcel, which is awesome, and also about localStorage (which I've been using IndexedDB instead).

Congrats!

[wojtekmaj]

Hmmm, I'll give it a thought ;) Let me convert this PR into an issue.

Regarding the source code - that was actually my biggest complaint about this code :D I coded it very fast and not thinking about it a lot. Now I ordered it and it's a lot better ;)