[breaking] Drop support for React content in customTextRenderer #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojtekmaj
force-pushed
the
no-server
branch
2 times, most recently
from
7b6d25e
to
f66b767
Compare
8 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #944, TextLayer was refactored to use pdf.js-native
pdfjs.renderTextLayerfor rendering text layer items.Keeping support for React content in
customTextRendereradds a dependency onreact-dom/serverwhich we need to import renderToStaticMarkup from. This makes bundles heavier and keeping compatibility with Preact harder.Users who still want to render React content may use
renderToStaticMarkupon their side, insidecustomTextRenderer.