Use public API for rendering cancellation #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how switching to public API could fix either of these issues, but it's definitely a welcome change. |
wojtekmaj
changed the title
|
Released with v5.3.0-beta.3 - I'd appreciate if you had a look if everything works properly and leave feedback in #748! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
page.renderreturnsRenderTaskinstance https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L1216-L1220that has
cancelmethod https://github.com/mozilla/pdf.js/blob/master/src/display/api.js#L2929-L2935Do you have any secret reason to use private API for cancelation? If not, this PR uses public 馃槍
Related to #736
Related to #374