Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wokwi CI - Support for rotating screenshots #670

Closed
georgik opened this issue Nov 2, 2023 · 1 comment
Closed

Wokwi CI - Support for rotating screenshots #670

georgik opened this issue Nov 2, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@georgik
Copy link

georgik commented Nov 2, 2023

Current state: Wokwi CI is able to take a screenshot, but it does not take into account orientation of simulated display. User needs to rotate the screenshot afterwards using tool like ImageMagic which might not be present in CI build container.

Example of diagram.json: https://github.com/georgik/esp32-spooky-maze-game/blob/main/esp-wrover-kit/diagram.json#L18

Desired state: Image is rotated, either by using the information from diagram.json or from a CLI parameter.

@georgik georgik added the enhancement New feature or request label Nov 2, 2023
@urish urish self-assigned this Nov 8, 2023
@urish
Copy link
Contributor

urish commented Nov 8, 2023

The CI should now take into account the "rotate" value from the diagram (it only works for right angle rotations, i.e. 90 / 180 / 270 degrees)

@urish urish closed this as completed Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants